Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not touch a doc file if it has not changed #544

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

jnavila
Copy link
Collaborator

@jnavila jnavila commented Nov 17, 2024

Writing the same file changes the timestamp, which is not good for use in Makefile dependencies. This commit avoids writing a doc file if the content has not changed from what is already in the file.

@jnavila jnavila marked this pull request as draft November 17, 2024 21:59
@Fat-Zer
Copy link
Contributor

Fat-Zer commented Nov 18, 2024

besides failing test: the po4a script uses spaces rather than tab-space mix for line shifts.

PS: the same problem was in #539, but I haven't noticed it before...

@jnavila
Copy link
Collaborator Author

jnavila commented Nov 18, 2024

besides failing test: the po4a script uses spaces rather than tab-space mix for line shifts.

PS: the same problem was in #539, but I haven't noticed it before...

OK, This is due to me mixing git and po4a development. Will reroll and fix the tabs.

@jnavila jnavila force-pushed the do_no_touch_doc_if_no_change branch from 61038c6 to 37cbef4 Compare November 18, 2024 21:51
Writing the same file changes the timestamp, which is not good for
use in Makefile dependencies. This commit avoids writing a doc file if
the content has not changed from what is already on the hard drive.

Signed-off-by: Jean-Noël Avila <[email protected]>
@jnavila jnavila force-pushed the do_no_touch_doc_if_no_change branch from 37cbef4 to 9b15388 Compare December 22, 2024 17:06
@jnavila jnavila marked this pull request as ready for review December 22, 2024 17:33
@mquinson mquinson merged commit 5d16870 into mquinson:master Dec 22, 2024
1 check passed
@jnavila jnavila deleted the do_no_touch_doc_if_no_change branch December 23, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants