Remove the REDIS_CONTAINER_NAME environment variable. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrq already respects the REDIS_URL if no host is given. That is more general than just a container name, since it could be running on a different port / outside of Docker / over TLS / require a password.
M-Kusumgar
approved these changes
Jan 10, 2025
plietar
added a commit
to mrc-ide/packit
that referenced
this pull request
Jan 13, 2025
I've removed support for the REDIS_CONTAINER_NAME environment variable from the runner implementation (mrc-ide/orderly.runner#14). rrq already allows natively supports configuration from the REDIS_URL, which is strictly more general.
Using finalizers to do this causes some tests to become flaky, as the queue is destroyed too early. I'm not convinced destroying the queue is even useful or desirable in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rrq already respects the REDIS_URL if no host is given. That is more general than just a container name, since it could be running on a different port / outside of Docker / over TLS / require a password.