fix: correct clause in SSL closed message and handle GenServer logger crash

[mrdotb]

• Fixes a clause error in the SSL closed message introduced in ssl error presence #45
• Addresses a GenServer crash that was breaking the logger handler

Contributor checklist

• My commit messages follow the Conventional Commit Message Format
  For example: fix: Multiply by appropriate coefficient, or
  feat(Calculator): Correctly preserve history
  Any explanation or long form information in your commit message should be
  in a separate paragraph, separated by a blank line from the primary message
• Bug fixes include regression tests

[martosaur]

Great catch on the Transport error incorrect tuple!

For the failing logger handler, I reproduced this scenario and this is the actual stacktrace:

19:22:04.850 [debug] [logger: :removed_failing_handler, handler: {:"test with a crashing GenServer GenServer crash should not crash the logger handler", DiscoLog.LoggerHandler}, 
  log_event: %{
    meta: %{
      error_logger: %{
        tag: :error,
        report_cb: &:gen_server.format_log/1
      },
      line: 2646,
      pid: #PID<0.255.0>,
      time: 1737084124836572,
      file: ~c"gen_server.erl",
      gl: #PID<0.69.0>,
      domain: [:otp],
      mfa: {:gen_server, :error_info, 8},
      report_cb: &:gen_server.format_log/2,
      crash_reason: {{:error, nil, %Mint.TransportError{reason: :closed}, []}, []}
    },
    msg: {:string, [
      ["GenServer ", "{DiscoLog.Registry, DiscoLog.Presence}", " terminating",
       ["\n** (stop) " | "{:error, nil, %Mint.TransportError{reason: :closed}, []}"], 
       [], "\nLast message", [], ": ", "{:ssl, :fake_ssl_closed}"],
      "\nState: ",
      "%DiscoLog.Presence{
         discord: DiscoLog.DiscordMock,
         discord_config: %DiscoLog.Discord.Config{
           category: %{name: \"disco-log\", type: 4},
           tags: [\"plug\", \"live_view\", \"oban\"],
           occurrences_channel: %{
             name: \"occurrences\",
             type: 15,
             available_tags: [%{name: \"plug\"}, %{name: \"live_view\"}, %{name: \"oban\"}]
           },
           info_channel: %{name: \"info\", type: 0},
           error_channel: %{name: \"error\", type: 0},
           token: \"mytoken\",
           guild_id: \"guild_id\",
           category_id: \"category_id\", 
           occurrences_channel_id: \"occurences_channel_id\",
           occurrences_channel_tags: %{},
           info_channel_id: \"info_channel_id\",
           error_channel_id: \"error_channel_id\",
           enable_discord_log: false
         },
         presence_status: \"🪩 Disco Logging\",
         registry: nil,
         websocket_client: %DiscoLog.WebsocketClient{
           conn: nil,
           websocket: %Mint.WebSocket{
             extensions: [],
             fragment: nil,
             private: %{},
             buffer: \"\"
           },
           ref: nil,
           state: :closed
         },
         jitter: 0.7958348364490507,
         heartbeat_interval: nil,
         sequence_number: nil,
         waiting_for_ack?: nil
       }"
    ]},
    level: :error
  },
  config: %{
    id: :"test with a crashing GenServer GenServer crash should not crash the logger handler",
    module: DiscoLog.LoggerHandler,
    config: %{
      metadata: [],
      enable: true,
      token: "mytoken",
      otp_app: :foo,
      guild_id: "guild_id",
      category_id: "category_id",
      occurrences_channel_id: "occurences_channel_id", 
      info_channel_id: "info_channel_id",
      error_channel_id: "error_channel_id",
      discord: DiscoLog.DiscordMock,
      enable_presence: true,
      repo_url: "",
      discord_config: %DiscoLog.Discord.Config{
        category: %{name: "disco-log", type: 4},
        tags: ["plug", "live_view", "oban"],
        occurrences_channel: %{
          name: "occurrences",
          type: 15,
          available_tags: [%{name: "plug"}, %{name: "live_view"}, %{name: "oban"}]
        },
        info_channel: %{name: "info", type: 0},
        error_channel: %{name: "error", type: 0},
        token: "mytoken",
        guild_id: "guild_id",
        category_id: "category_id",
        occurrences_channel_id: "occurences_channel_id",
        occurrences_channel_tags: %{},
        info_channel_id: "info_channel_id",
        error_channel_id: "error_channel_id",
        enable_discord_log: false
      },
      presence_status: "🪩 Disco Logging",
      supervisor_name: DiscoLog,
      enable_logger: true,
      instrument_phoenix: true,
      instrument_oban: true,
      instrument_tesla: true,
      enable_discord_log: false,
      excluded_domains: [:cowboy, :bandit],
      before_send: nil,
      enable_go_to_repo: false,
      go_to_repo_top_modules: [],
      git_sha: ""
    },
    formatter: {:logger_formatter, %{}}
  },
  reason: {:error, :function_clause, [
    {DiscoLog.Error, :normalize_exception, [{:error, nil, %Mint.TransportError{reason: :closed}, []}, []], [file: ~c"lib/disco_log/error.ex", line: 58]},
    {DiscoLog.Error, :new, 4, [file: ~c"lib/disco_log/error.ex", line: 23]},
    {DiscoLog.LoggerHandler, :log_from_crash_reason, 4, [file: ~c"lib/disco_log/logger_handler.ex", line: 174]}
  ]}
]

I think for a solid fix it would be nice to allow DiscoLog.Error to work with any reason, since it looks like it can be any arbitrary value from the genserver exit? Doesn't have to be in this PR of course

[mrdotb]

👋
Could you share how you trigger the error from test GenServer ?
In my current test I pass the error manually to the Logger because I could not reproduce the error from the test GenServer.

I think for a solid fix it would be nice to allow DiscoLog.Error to work with any reason, since it looks like it can be any arbitrary value from the genserver exit?

The genserver exit are covered.
In this case It seems that there 2 error wrapped if the way I test it is correct because I could not reproduce it with GenServer test.

%{
  meta: %{
    line: 416,
    pid: #PID<0.247.0>,
    time: 1737107615148176,
    file: ~c"/home/john/Projects/elixir/disco-log/test/disco_log/logger_handler_test.exs",
    gl: #PID<0.70.0>,
    domain: [:elixir],
    mfa: {DiscoLog.LoggerHandlerTest,
     :"test with a crashing GenServer GenServer crash should not crash the logger handler",
     1}
  },
  msg: {:report,
   %{
     meta: %{
       domain: [:otp],
       mfa: {:gen_server, :error_info, 8},
       report_cb: &:gen_server.format_log/2,
       crash_reason: {{:error,
         %Mint.HTTP1{
           host: nil,
           port: nil,
           request: nil,
           streaming_request: nil,
           socket: nil,
           transport: nil,
           mode: nil,
           scheme_as_string: nil,
           case_sensitive_headers: nil,
           requests: {[], []},
           state: :closed,
           buffer: "",
           proxy_headers: [],
           private: %{},
           log: false
         }, %Mint.TransportError{reason: :closed}, []}, []}
     },
     msg: {:string,
      [
        ["GenServer ", "{DiscoLog.Registry, DiscoLog.Presence}", " terminating"],
        ["\n** (stop) ",
         "{:error, %Mint.HTTP1{host: \"gateway.discord.gg\", port: 443, request: nil, streaming_request: nil, ... }"],
        "\nLast message: ",
        "{:ssl_closed, {:sslsocket, {:gen_tcp, 12345, :tls_connection, :undefined}, [self(), self()]}}",
        "\nState: ",
        "%DiscoLog.Presence{discord: DiscoLog.Discord, ... }"
      ]},
     level: :error
   }},
  level: :error
}

[martosaur]

Sure, here's a branch with the test https://github.com/mrdotb/disco-log/tree/am/fix/presence-ssl-error

The error and logger failure message matches what I see in my app when this happens.

[mrdotb]

👍 Thanks for the help.
I found where the logger break with your test setup and fixed it.