Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comma starting a wrapped value broke the line #271

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

sevrai
Copy link
Contributor

@sevrai sevrai commented Jan 24, 2025

Background Information

If a comma (or any field delimiter) is starting a wrapped cell, then the cell is not escaped as a wrapped value and the whole line is broken

I have...

  • added at least one test to verify the failure condition is fixed.
  • verified the tests are passing.

@coveralls
Copy link

Coverage Status

coverage: 98.058%. remained the same
when pulling 3a8ce35 on sevrai:fix/field-after-wrap
into ffada90 on mrodrig:main.

@mrodrig
Copy link
Owner

mrodrig commented Jan 24, 2025

Thanks for reporting this and the pull request @sevrai! I'll get this merged in and published to NPM shortly.

@mrodrig mrodrig merged commit 1b75a88 into mrodrig:main Jan 24, 2025
5 checks passed
@sevrai sevrai deleted the fix/field-after-wrap branch January 27, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants