Added additional test for the Department method.

mrstebo · Feb 3, 2019 · d22a8f0 · d22a8f0
1 parent 976309a
commit d22a8f0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/FakerDotNet/Fakers/CommerceFaker.cs b/src/FakerDotNet/Fakers/CommerceFaker.cs
@@ -32,11 +32,10 @@ public string Color()
         public string Department(int max = 3, bool fixedAmount = false)
         {
             var num = fixedAmount ? max : Convert.ToInt32(_fakerContainer.Number.Between(1, max));
-
-            if (num <= 1) return _fakerContainer.Random.Element(CommerceData.Departments);
-
             var departments = _fakerContainer.Random.Assortment(CommerceData.Departments, num).ToArray();
 
+            if (num == 1) return departments[0];
+
             return string.Join(" & ",
                 string.Join(", ", departments.Take(departments.Length - 1)),
                 departments.Last());

diff --git a/tests/FakerDotNet.Tests/Fakers/CommerceFakerTests.cs b/tests/FakerDotNet.Tests/Fakers/CommerceFakerTests.cs
@@ -59,6 +59,15 @@ public void Department_returns_a_department_with_a_fixed_number_of_categories()
             Assert.AreEqual("Books & Tools", _commerceFaker.Department(2, true));
         }
 
+        [Test]
+        public void Department_returns_single_department_if_only_one_department_requested()
+        {
+            A.CallTo(() => _fakerContainer.Random.Assortment(CommerceData.Departments, 1))
+                .Returns(new[] {"Health"});
+
+            Assert.AreEqual("Health", _commerceFaker.Department(1, true));
+        }
+
         [Test]
         public void Material_returns_a_material()
         {