backup: add option --exclude to skip matching file paths from bind mounts #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muesli
reviewed
Apr 30, 2021
| @@ -178,7 +211,8 @@ func backup(ID string) error { | |||
| return err | |||
| } | |||
|
|
|||
| for _, m := range conf.Mounts { | |||
| paths = []string{} | |||
There was a problem hiding this comment.
Please make sure your sources are always gofmt'd before pushing! It's the best thing since sliced bread, really 😃
There was a problem hiding this comment.
Ah, I didn't know about that command - I'll try it out!
muesli
reviewed
Apr 30, 2021
| if mount.Type == "bind" { | ||
| skip := false | ||
| for _, exclude := range optExclude { | ||
| if strings.HasPrefix(mount.Source, exclude) { |
There was a problem hiding this comment.
From a user's perspective, I wonder if we shouldn't support globbing here.
There was a problem hiding this comment.
I did wonder about that, either glob or regex. I'm not sure how common that need would be though, to exclude a more complex pattern of files in a bind (rather than entire folders/trees). The question then is, do you match glob/regex against the path to the bind, or individually against all the files searched in the bind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18