[Slider] Prevent range slider thumbs from being dragged past each other #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
component: slider
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Add a test Add a test
mj12albert
force-pushed
the
fix/range-thumb-overlap
branch
from
8ac284e to
bf35e76
Compare
mj12albert
commented
Mar 28, 2025
mj12albert
changed the title
atomiks
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1602
Demo: https://codesandbox.io/p/sandbox/great-wu-p6trjf
The issue was that
percentageValueswhich determines the positioning also need to be clamped with adjacent values in range sliders like the value itself