Fix: [Tooltip] When wrapping an input which is disabled… #45378
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… while focused an error is thrown mui#45373 Signed-off-by: Sarathkumar <[email protected]>
Netlify deploy previewhttps://deploy-preview-45378--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
zannager
added
the
component: tooltip
mj12albert
reviewed
Feb 24, 2025
mj12albert
changed the title
… while focused an error is thrown mui#45373 Signed-off-by: Sarathkumar <[email protected]>
… while focused an error is thrown mui#45373 Fixed linting issue. Signed-off-by: Sarathkumar <[email protected]>
|
Hi @siriwatknp, please review the fix when you are free. |
mj12albert
requested changes
Feb 26, 2025
| @@ -492,7 +492,7 @@ const Tooltip = React.forwardRef(function Tooltip(inProps, ref) { | |||
| setChildNode(event.currentTarget); | |||
| } | |||
|
|
|||
| if (isFocusVisible(event.target)) { | |||
| if (event && isFocusVisible(event.target)) { | |||
There was a problem hiding this comment.
@sarathkumarsasi Did you test that this fixes the issue?
Please see the diff I posted, I think the problem is in handleBlur and not handleFocus: #45373 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… while focused an error is thrown #45373