[docs][data grid] Copyedit the Aggregation doc #16200
Open
+71
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelsycamore
added
docs
|
Deploy preview: https://deploy-preview-16200--material-ui-x.netlify.app/ Updated pages: |
samuelsycamore
requested review from
KenanYusuf,
michelengelen and
alelthomas
samuelsycamore
added
the
feature: Aggregation
|
|
||
| You can aggregate rows through the Data Grid interface by opening the column menu and selecting from the items under **Aggregation**. | ||
| The Data Grid Premium provides tools to give end users the ability to aggregate and compare row values. | ||
| It includes [built-in functions](#built-in-functions) to cover common use cases such as sum, average, minimum, and maximum, as well as the means to [create custom functions](#creating-custom-functions) for all other needs. |
There was a problem hiding this comment.
not sure if there should be a , here
Suggested change
| It includes [built-in functions](#built-in-functions) to cover common use cases such as sum, average, minimum, and maximum, as well as the means to [create custom functions](#creating-custom-functions) for all other needs. | |
| It includes [built-in functions](#built-in-functions) to cover common use cases such as sum, average, minimum and maximum, as well as the means to [create custom functions](#creating-custom-functions) for all other needs. |
There was a problem hiding this comment.
That's called an Oxford (or serial) comma, and I'm a big fan of it. 😁 It seems like a very minor detail but English can be a pretty ambiguous language so I always prefer to err on the side of clarity. In one case, the lack of an Oxford comma in an employment contract led to a successful multi-million-dollar lawsuit!
Co-authored-by: Michel Engelen <[email protected]> Signed-off-by: Sycamore <[email protected]>
Co-authored-by: Michel Engelen <[email protected]> Signed-off-by: Sycamore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the ongoing auditing/editing project, prioritizing Premium and Pro docs.
This page has undergone an editorial review in the recent past so it's mostly in good shape already, but I did find some quick and easy improvements to make, such as writing an informative intro, tweaking the header architecture, and rephrasing things from future to present tense.