[charts-pro] Fix pro components watermark
#16222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCQuintas
added
bug 🐛
|
Deploy preview: https://deploy-preview-16222--material-ui-x.netlify.app/ Updated pages: |
CodSpeed Performance ReportMerging #16222 will not alter performanceComparing Summary
|
alexfauquette
approved these changes
Jan 17, 2025
scripts/x-charts-pro.exports.json
Outdated
Comment on lines
58
to
60
| { "name": "ChartDataProviderPro", "kind": "Function" }, | ||
| { "name": "ChartDataProviderProProps", "kind": "TypeAlias" }, | ||
| { "name": "ChartDrawingArea", "kind": "TypeAlias" }, |
There was a problem hiding this comment.
I would be in favor of adding an export of the MIT container in packages/x-charts-pro/src/index.ts such that pro users can both have the provider with and without zoom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChartDataProviderProwhich checks and displays the watermark.ChartsContainerProas it usesChartDataProviderProunder the hood/context/ChartDataProviderto/ChartDataProviderto be easier to use