-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Standardize getting started docs across all packages #16302
Conversation
Deploy preview: https://deploy-preview-16302--material-ui-x.netlify.app/ Updated pages: |
docs/.link-check-errors.txt
Outdated
- https://mui.com/x/react-charts/getting-started/ | ||
- https://mui.com/x/react-data-grid/#premium-plan | ||
- https://mui.com/x/react-data-grid/getting-started/ | ||
- https://mui.com/x/react-data-grid/getting-started/#feature-comparison | ||
- https://mui.com/x/react-date-pickers/fields/#accessible-dom-structure | ||
- https://mui.com/x/react-date-pickers/getting-started/ | ||
- https://mui.com/x/react-tree-view/#rich-tree-view | ||
- https://mui.com/x/react-tree-view/#simple-tree-view | ||
- https://mui.com/x/react-tree-view/getting-started/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand things, we should fix those
- https://mui.com/x/react-charts/getting-started/ | |
- https://mui.com/x/react-data-grid/#premium-plan | |
- https://mui.com/x/react-data-grid/getting-started/ | |
- https://mui.com/x/react-data-grid/getting-started/#feature-comparison | |
- https://mui.com/x/react-date-pickers/fields/#accessible-dom-structure | |
- https://mui.com/x/react-date-pickers/getting-started/ | |
- https://mui.com/x/react-tree-view/#rich-tree-view | |
- https://mui.com/x/react-tree-view/#simple-tree-view | |
- https://mui.com/x/react-tree-view/getting-started/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're all coming from the Material UI docs and MUI blog - PR to fix them here: mui/material-ui#45145
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for the context. This seems related to mui/base-ui#552.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement and alignment between products. 👍
I'm not 100% sure about FAQ removals, but if you really think that they don't make sense, I don't mind. 👌
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Co-authored-by: Alexandre Fauquette <[email protected]> Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Sam Sycamore <[email protected]>
Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Sam Sycamore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements, I've reviewed charts and generic changes though. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the massive cleaning 🙏
Follow-up to #15757, applying the same patterns from the Data Grid getting started docs to the other X components for a more consistent and predictable experience.
With this PR, all 4 packages now have 2 pages in the Getting Started sequence:
Considerations:
Questions:
Notes: