Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Reduce chart perf benchmark weight #16374

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

alexfauquette
Copy link
Member

This PR is here to reduce the size of the perf bechnmark to make sure #16211 is not degrading perfs

@alexfauquette alexfauquette added the component: charts This is the name of the generic UI component, not the React module! label Jan 28, 2025
@mui-bot
Copy link

mui-bot commented Jan 28, 2025

Deploy preview: https://deploy-preview-16374--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 6b16d6e

Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Performance Report

Merging #16374 will degrade performances by 72.22%

Comparing alexfauquette:reduce-perf-consumption (6b16d6e) with master (cbe47de)

Summary

⚡ 5 improvements
❌ 1 (👁 1) regressions

Benchmarks breakdown

Benchmark BASE HEAD Change
BarChart with big data amount 923.9 ms 518.6 ms +78.14%
👁 BarChartPro with big data amount 218 ms 784.9 ms -72.22%
LineChart with big data amount 975.6 ms 280.8 ms ×3.5
LineChartPro with big data amount 528.6 ms 125.8 ms ×4.2
ScatterChart with big data amount 479.2 ms 390.3 ms +22.78%
ScatterChartPro with big data amount 125.7 ms 52.6 ms ×2.4

@alexfauquette alexfauquette merged commit 59109b9 into mui:master Jan 28, 2025
16 of 17 checks passed
A-s-h-o-k pushed a commit to A-s-h-o-k/mui-x that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants