[DataGrid] Refactor: create base Autocomplete #16390
Open
+216
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
the
component: data grid
romgrk
commented
Jan 29, 2025
Comment on lines
+57
to
+59
| const BaseAutocomplete = rootProps.slots.baseAutocomplete as React.JSXElementConstructor< | ||
| AutocompleteProps<string, true, false, true> | ||
| >; |
There was a problem hiding this comment.
We can't have type parameters directly on GridBaseSlots['baseAutocomplete'], the parameters would need to be on GridBaseSlots and that would make using that type extremely tedious.
|
Deploy preview: https://deploy-preview-16390--material-ui-x.netlify.app/ |
…i-x into refactor-agnostic-autocomplete
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the design-system agnostic work.
The base Autocomplete API is a subset of the material one, with minor changes (
label,placeholder,slotProps.textField).