[charts] Move Voronoi handler in a dedicated plugin #16470
Conversation
|
Deploy preview: https://deploy-preview-16470--material-ui-x.netlify.app/ Updated pages: |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
| * @param scale The scale to use | ||
| * @returns (value: any) => number | ||
| */ | ||
| export function getValueToPositionMapper(scale: D3Scale) { |
There was a problem hiding this comment.
extracted from the useScale.ts
| export const selectorChartZoomIsInteracting = createSelector( | ||
| selectorChartZoomState, | ||
| (zoom) => zoom?.isInteracting, | ||
| ); | ||
|
|
There was a problem hiding this comment.
The selector got moved to the communit packeg to be able to stop voronoi computation during the zoom
alexfauquette
added
breaking change
component: charts
CodSpeed Performance ReportMerging #16470 will not alter performanceComparing Summary
|
|
Tests are failing because of changes in this PR |
Nice it also helped me to realise I messed a bit with the |
|
The remaining failing test came from the fact that when voronoi is enabled it should be the source of truth an so pointerEnter should not trigger interaction. Seems the behavior was buggy an fixed by this PR. Investigation let me also noticed one prop was not properly propagated. So I added a test on scatter chart such that the tooltip got test for both voronoi and item interacion |
| fireEvent.pointerMove(svg, { | ||
| clientX: 10, | ||
| clientY: 10, | ||
| }); // Set tooltip position voronoi value |
There was a problem hiding this comment.
Odd that this was necessary 🤔
I suppose it is because it is using fireEvent instead of userEvent, which would handle moving/hover/etc
Remove the Voronoi handler and make it aplugins.
In addition, we only compute the delauney graph when the zoom is not active