[charts] Add color prop to Sparkline and deprecate colors
#16477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardobelchior
added
component: charts
|
Deploy preview: https://deploy-preview-16477--material-ui-x.netlify.app/ Updated pages: |
CodSpeed Performance ReportMerging #16477 will not alter performanceComparing Summary
|
bernardobelchior
force-pushed
the
sparkline-color
branch
from
51a4174 to
ecdb48c
Compare
bernardobelchior
changed the title
color prop to Sparkline. Deprecated colors. Update colors defaults.color prop to Sparkline and deprecate colors
bernardobelchior
force-pushed
the
sparkline-color
branch
from
9e53d77 to
5d122ad
Compare
JCQuintas
reviewed
Feb 6, 2025
| @@ -82,7 +82,7 @@ ChartDataProviderPro.propTypes = { | |||
| children: PropTypes.node, | |||
| /** | |||
| * Color palette used to colorize multiple series. | |||
| * @default rainbowSurgePalette | |||
| * @default blueberryTwilightPalette | |||
There was a problem hiding this comment.
Why was this changed from rainbowSurgePalette to blueberryTwilightPalette? Rainbow surge is the new one and should be the default
There was a problem hiding this comment.
Not sure, it wasn't intended.
Before I had the update to the default color in this PR as well, but when I moved it into a different one I must have messed something up. It's fixed now!
JCQuintas
reviewed
Feb 6, 2025
| @@ -17,7 +17,7 @@ export interface UseChartSeriesParameters<T extends ChartSeriesType = ChartSerie | |||
| series?: AllSeriesType<T>[]; | |||
| /** | |||
| * Color palette used to colorize multiple series. | |||
| * @default rainbowSurgePalette | |||
| * @default blueberryTwilightPalette | |||
JCQuintas
approved these changes
Feb 6, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
colorprop toSparkLineChartand deprecatecolors. The reasoning is explained in this comment.Fixes #11707.