Update generate_social_blocklists_asn.py #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: 🛡️ Improved ASN to RPZ generator 🚀 - ✨ Enhanced error handling and robustness. - 🔒 Added HTTP error handling and timeouts. - 🧹 Cleaned up network prefix processing. - 📈 Enhanced readability and maintainability. - 📊 Added validation and error messages. - 📝 Improved comments and clarity. - ✅ Added output directory creation. - ✅ Added ipaddress module usage for better validation. Rationale: This commit enhances the ASN to RPZ generator script to improve its robustness, security, and maintainability. It introduces better error handling using `try-except` blocks, adds HTTP error handling and timeouts, ensures network prefixes are properly processed using the `ipaddress` module, and adds informative messages. It also includes output directory creation and improved comments. 🍻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: 🛡️ Improved ASN to RPZ generator 🚀
Rationale:
This commit enhances the ASN to RPZ generator script to improve its robustness, security, and maintainability. It introduces better error handling using
try-exceptblocks, adds HTTP error handling and timeouts, ensures network prefixes are properly processed using theipaddressmodule, and adds informative messages. It also includes output directory creation and improved comments. 🍻