Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add epoch field for transactions #1464

Merged
merged 4 commits into from
Mar 24, 2025
Merged

Conversation

bogdan-rosianu
Copy link
Contributor

Reasoning

  • transaction's epoch is exposed by gateway/indexer (even though not all the transactions had this record yet)

Proposed Changes

  • extend Transaction structure so the epoch field will exist if fetched from external systems

How to test

@bogdan-rosianu bogdan-rosianu self-assigned this Mar 14, 2025
Copy link

github-actions bot commented Mar 14, 2025

k6 load testing comparison.
Base Commit Hash: 958d9d0
Target Commit Hash: d0dee6f

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Nodes48.07970.2650.7352.5348.54355.6552.7554.45+0.99% 🔴-63.35% ✅+3.99% 🔴+3.65% 🔴
Blocks53.251132.0051.3253.3655.421444.7453.2255.51+4.08% 🔴+27.63% 🔴+3.70% 🔴+4.02% 🔴
Mex46.93147.2550.9052.5848.43311.1952.7254.41+3.20% 🔴+111.34% 🔴+3.58% 🔴+3.47% 🔴
Transactions59.401376.8951.4654.0462.021803.9753.1455.30+4.41% 🔴+31.02% 🔴+3.27% 🔴+2.34% 🔴
Pool47.58650.4750.8752.6848.78568.6952.7554.51+2.52% 🔴-12.57% ✅+3.69% 🔴+3.47% 🔴
Tokens47.48502.0950.9452.6448.89644.4652.7054.39+2.96% 🔴+28.36% 🔴+3.45% 🔴+3.32% 🔴
Accounts47.78601.1650.8452.3249.32888.6552.5554.23+3.24% 🔴+47.82% 🔴+3.36% 🔴+3.66% 🔴
Test Run Duration60006.5660002.07

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@cfaur09 cfaur09 merged commit fb35d87 into development Mar 24, 2025
6 checks passed
@cfaur09 cfaur09 deleted the add-transaction-epoch-field branch March 24, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants