Release specs v1.9.0 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasurobert
previously approved these changes
Mar 21, 2025
mariusmihaic
previously approved these changes
Mar 21, 2025
AdoAdoAdo
reviewed
Mar 24, 2025
|
|
||
| Previously, only the leader handled the aggregated signature and set it on the initially proposed block, but now it can be created and propagated as a separate equivalent proof by every eligible node in consensus. These proofs are equivalent since they represent a majority from the eligible nodes in consensus. | ||
|
|
||
| The proof will be propagated in the network only if it was created directly. Otherwise, it will not be further propagated when received from other nodes in the network, to avoid flooding. |
There was a problem hiding this comment.
An equivalent consensus proof will be propagated only once by every node, either if it was created by the node or if it was the first proof received and validated by the node.
| - [#4819](https://github.com/multiversx/mx-chain-go/pull/4819) - Fixes for nodes coordinator with chain parameters | ||
| - [#4927](https://github.com/multiversx/mx-chain-go/pull/4927) - Chain parameters notifier | ||
|
|
||
| ## 2. Equivalent proofs [#5786](https://github.com/multiversx/mx-chain-go/pull/5786) |
There was a problem hiding this comment.
Can we split this into 2 parts?
-
Fixed ordering in consensus
-
Equivalent proofs
AdoAdoAdo
reviewed
Mar 24, 2025
|
|
||
| This document explains the contents of the release codenamed Andromeda. | ||
|
|
||
| Although it can be considered one big feature, this document is split into 2 features, containing detailed insights of the feature along with the external impact and the relevant pull requests list. |
sstanculeanu
dismissed stale reviews from mariusmihaic and sasurobert
via
5d8a3a3
AdoAdoAdo
reviewed
Mar 24, 2025
|
|
||
| ## 2. Fixed ordering in consensus [#6436](https://github.com/multiversx/mx-chain-go/pull/6436) | ||
|
|
||
| Each eligible node is now required to sign, as the order of signing was moved to a fixed 400 value. |
There was a problem hiding this comment.
each eligible node is required to sign and the order of signatures aggregation was fixed to the order of the eligible nodes decided at epoch start.
AdoAdoAdo
reviewed
Mar 24, 2025
|
|
||
| An equivalent consensus proof will be propagated only once by every node, either if it was created by the node or if it was the first proof received and validated by the node. | ||
|
|
||
| The proof for the current block will be included in the next block structure. A particular block is considered final if there is an equivalent proof for it. |
sasurobert
approved these changes
Mar 24, 2025
mariusmihaic
approved these changes
Mar 24, 2025
AdoAdoAdo
approved these changes
Mar 24, 2025
schimih
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.