Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use ce-la-react to add type definitions for JSX attributes #1068

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ronalduQualabs
Copy link

This PR fix this issue by:

  • Add ce-la-react
  • Modify the build.js in react to use ce-la-react
  • Add attributes as properties to create type definitions
  • Remove the creation of the d.ts files in build since the new implementation generate them.
  • move some components imports to be found in ce-la-react

Note: Styles inline need to be set as any to don't have a warning from typescript error.

Screenshot 2025-02-05 at 4 06 15 PM

@ronalduQualabs ronalduQualabs requested review from heff and a team as code owners February 5, 2025 19:08
Copy link

vercel bot commented Feb 5, 2025

@ronalduQualabs is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant