fix: add back 3.5.0 API

muxinc · Jan 29, 2024 · 8de2082 · 8de2082
1 parent a140564
commit 8de2082
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 14 deletions.
diff --git a/MUXSDKStats/MUXSDKStats/MUXSDKPlayerBinding.h b/MUXSDKStats/MUXSDKStats/MUXSDKPlayerBinding.h
@@ -116,6 +116,7 @@ typedef NS_ENUM(NSUInteger, MUXSDKViewOrientation) {
 - (BOOL)setAutomaticErrorTracking:(BOOL)automaticErrorTracking;
 - (BOOL)setAutomaticVideoChange:(BOOL)automaticVideoChange;
 - (void)dispatchError:(NSString *)code withMessage:(NSString *)message;
+- (void)dispatchError:(NSString *)code withMessage:(NSString *)message withErrorContext:(NSString *)errorContext;
 - (void)didTriggerManualVideoChange;
 
 #pragma clang diagnostic pop

diff --git a/MUXSDKStats/MUXSDKStats/MUXSDKPlayerBinding.m b/MUXSDKStats/MUXSDKStats/MUXSDKPlayerBinding.m
@@ -889,29 +889,23 @@ - (void)dispatchTimeUpdateEvent:(CMTime)time {
     [MUXSDKCore dispatchEvent:event forPlayer:_name];
 }
 
-- (void)dispatchError {
-    if (!_automaticErrorTracking) {
-        return;
-    }
-    if (![self isPlayerOK]) {
-        return;
-    }
-    [self checkVideoData];
-    MUXSDKPlayerData *playerData = [self getPlayerData];
-    MUXSDKErrorEvent *event = [[MUXSDKErrorEvent alloc] init];
-    [event setPlayerData:playerData];
-    [MUXSDKCore dispatchEvent:event forPlayer:_name];
-    _state = MUXSDKPlayerStateError;
+- (void) dispatchError:(nonnull NSString *)code withMessage:(nonnull NSString *)message {
+    [self dispatchError:code withMessage:message withErrorContext:nil];
 }
 
-- (void) dispatchError:(nonnull NSString *)code withMessage:(nonnull NSString *)message {
+- (void) dispatchError:(nonnull NSString *)code
+           withMessage:(nonnull NSString *)message
+      withErrorContext:(NSString *)errorContext {
     if (![self isPlayerOK]) {
         return;
     }
     [self checkVideoData];
     MUXSDKPlayerData *playerData = [self getPlayerData];
     [playerData setPlayerErrorCode:code];
     [playerData setPlayerErrorMessage:message];
+    if (errorContext) {
+        [playerData setPlayerErrorContext:errorContext];
+    }
     MUXSDKErrorEvent *event = [[MUXSDKErrorEvent alloc] init];
     [event setPlayerData:playerData];
     [MUXSDKCore dispatchEvent:event forPlayer:_name];

diff --git a/MUXSDKStats/MUXSDKStatsTests/MUXSDKPlayerBindingTests.m b/MUXSDKStats/MUXSDKStatsTests/MUXSDKPlayerBindingTests.m
@@ -213,6 +213,34 @@ - (void)testAVPlayerBindingAutomaticErrorTrackingEnabled {
 
 }
 
+- (void)testAVPlayerViewControllerBindingErrorMetadata {
+    NSString *name = @"awesome-player";
+    MUXSDKAVPlayerViewControllerBinding *binding = [self setupViewControllerPlayerBinding:name
+                                                                             softwareName:@"TestSoftware"
+                                                                          softwareVersion:@"0.1.0"];
+
+    [binding dispatchError:@"1" withMessage:@"message" withErrorContext:@"context"];
+
+    XCTAssertEqual(5, [MUXSDKCore eventsCountForPlayer:name]);
+    id<MUXSDKEventTyping> event = [MUXSDKCore eventAtIndex:4 forPlayer:name];
+    XCTAssertEqual([event getType], MUXSDKPlaybackEventErrorEventType);
+
+    MUXSDKPlaybackEvent *playbackEvent = (MUXSDKPlaybackEvent *)event;
+    XCTAssertEqual(
+                   playbackEvent.playerData.playerErrorCode,
+                   @"1"
+                   );
+    XCTAssertEqual(
+                   playbackEvent.playerData.playerErrorMessage,
+                   @"message"
+                   );
+    XCTAssertEqual(
+                   playbackEvent.playerData.playerErrorContext,
+                   @"context"
+                   );
+}
+
+
 - (void)testAVPlayerBindingAutomaticErrorTrackingDisabled {
     NSString *name = @"awesome-player";
     MUXSDKAVPlayerBinding *binding = [self setupAVPlayerBinding:name