fix: Manually reverted PR 11716 Do not assign all paired items (no-changelog) #13429
Conversation
| } | ||
| } | ||
| } | ||
|
|
||
| return workflowResult; | ||
| } catch (error) { | ||
| const pairedItem = generatePairedItemData(items.length); |
There was a problem hiding this comment.
This file had conflicts and I didn't add the PairedItems back to not break the new logic return [
[
{
json: { error: error.message },
metadata,
},
],
];
it was like this before the reverted PR
return [[{ json: { error: error.message }, pairedItem }]];
packages/nodes-base/nodes/ExecuteWorkflow/ExecuteWorkflow/ExecuteWorkflow.node.ts
Show resolved
Hide resolved
ShireenMissi
changed the title
n8n-assistant
bot
added
n8n team
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 04m 34s |
| Commit |
|
| Committer | Shireen Missi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
437
|
| View all changes introduced in this branch ↗︎ | |
ShireenMissi
force-pushed
the
node-2449-paired-items-are-removed
branch
from
86a66e5 to
72adfec
Compare
There was a problem hiding this comment.
The original PR changed also the catch handler:
Should we change it to:
} catch (error) {
const pairedItem = generatePairedItemData(items.length);
if (this.continueOnFail()) {
const metadata = parseErrorMetadata(error);
return [
[
{
json: { error: error.message },
metadata,
pairedItem
},
],
];
}
throw error;
}
}There was a problem hiding this comment.
Uff sorry, posted this to wrong file
There was a problem hiding this comment.
I meant packages/nodes-base/nodes/ExecuteWorkflow/ExecuteWorkflow/ExecuteWorkflow.node.ts
There was a problem hiding this comment.
I wasn't sure if I should chain metadata and pairedItem, I will do that just in case
There was a problem hiding this comment.
TBH I don't know. Just by looking at it, it seems to contain linkage between the workflow and execution, where as the paired item is linkage between items within the execution
ShireenMissi
added
the
release/backport
There was a problem hiding this comment.
This is not in the original PR?
There was a problem hiding this comment.
yes, I had to fix the test
the google sheet PR was merged after the original PR
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
|
✅ All Cypress E2E specs passed |
Summary
This PR reverts #11716
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2449/paired-items-are-removed
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)