-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpi tcpip doc #42
rpi tcpip doc #42
Conversation
Nice work! I'll try to take a closer look over the weekend here and see if I have any suggestions, but so far I see all the main stuff is covered. |
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
@2bndy5 , thanks for the precise suggestions. All suggestions are applied. |
@epsi1on I added the ability to preview doc changes in a PR using readthedocs. If you could git pull
git rebase upstream/master
git push --force |
@epsi1on My only real suggestion here is to modify the main docs page and add a link, probably under the installation section, to this new page. Title should be something like "Setup a RPi to RPi TCP/IP Link over nRF24L01" |
did it. |
I did edit main page and added a link at buttom. thanks to @2bndy5 it have a preview now: |
still not sure how to put the link for image |
Doxygen supports 2 syntax.
Note The image must be placed in the images folder, not the docs/images folder. I prefer to use method 1. If customizing the size of the image is desired then use method 2. |
It would be resolved now. Could you please do a check?! |
Co-authored-by: Brendan <[email protected]>
Odd, my suggestion didn't fix the image link. It looks like doxygen's config needs to be updated: Line 206 in 8b2afa7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit that fixed showing the image. LGTM now. Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Co-authored-by: Brendan <[email protected]>
I also cherry picked this patch to v1.x branch 😉 |
Thanks all |
as discussed in #41