Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpi tcpip doc #42

Merged
merged 26 commits into from
Feb 11, 2025
Merged

rpi tcpip doc #42

merged 26 commits into from
Feb 11, 2025

Conversation

epsi1on
Copy link
Contributor

@epsi1on epsi1on commented Feb 7, 2025

as discussed in #41

@TMRh20
Copy link
Member

TMRh20 commented Feb 7, 2025

Nice work! I'll try to take a closer look over the weekend here and see if I have any suggestions, but so far I see all the main stuff is covered.

2bndy5

This comment was marked as resolved.

epsi1on and others added 17 commits February 7, 2025 17:37
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
Co-authored-by: Brendan <[email protected]>
@epsi1on
Copy link
Contributor Author

epsi1on commented Feb 7, 2025

@2bndy5 , thanks for the precise suggestions. All suggestions are applied.
Regards

@2bndy5
Copy link
Member

2bndy5 commented Feb 7, 2025

@epsi1on I added the ability to preview doc changes in a PR using readthedocs. If you could rebase your branch on upstream's master branch, the docs preview will begin to show in this PR.

git pull
git rebase upstream/master
git push --force

Then we can access the docs preview from the "checks":
410972516-b763fbf6-a60a-4c63-a6a2-9690fa9280da

@TMRh20
Copy link
Member

TMRh20 commented Feb 10, 2025

@epsi1on My only real suggestion here is to modify the main docs page and add a link, probably under the installation section, to this new page. Title should be something like "Setup a RPi to RPi TCP/IP Link over nRF24L01"

@epsi1on
Copy link
Contributor Author

epsi1on commented Feb 11, 2025

@epsi1on I added the ability to preview doc changes in a PR using readthedocs. If you could rebase your branch on upstream's master branch, the docs preview will begin to show in this PR.

git pull
git rebase upstream/master
git push --force

Then we can access the docs preview from the "checks": 410972516-b763fbf6-a60a-4c63-a6a2-9690fa9280da

did it.

@epsi1on
Copy link
Contributor Author

epsi1on commented Feb 11, 2025

@epsi1on My only real suggestion here is to modify the main docs page and add a link, probably under the installation section, to this new page. Title should be something like "Setup a RPi to RPi TCP/IP Link over nRF24L01"

I did edit main page and added a link at buttom. thanks to @2bndy5 it have a preview now:

https://rf24gateway--42.org.readthedocs.build/en/42/

@epsi1on
Copy link
Contributor Author

epsi1on commented Feb 11, 2025

still not sure how to put the link for image

@2bndy5
Copy link
Member

2bndy5 commented Feb 11, 2025

still not sure how to put the link for image

Doxygen supports 2 syntax.

  1. Using markdown syntax
  2. Using doxygen's @image command

Note

The image must be placed in the images folder, not the docs/images folder.

I prefer to use method 1. If customizing the size of the image is desired then use method 2.

@epsi1on
Copy link
Contributor Author

epsi1on commented Feb 11, 2025

still not sure how to put the link for image

Doxygen supports 2 syntax.

1. Using [markdown syntax](https://www.doxygen.nl/manual/markdown.html#md_images)

2. Using [doxygen's `@image` command](https://www.doxygen.nl/manual/commands.html#cmdimage)

Note

The image must be placed in the images folder, not the docs/images folder.

I prefer to use method 1. If customizing the size of the image is desired then use method 2.

It would be resolved now. Could you please do a check?!

@2bndy5
Copy link
Member

2bndy5 commented Feb 11, 2025

Odd, my suggestion didn't fix the image link. It looks like doxygen's config needs to be updated:

IMAGE_PATH = ../examples/ncurses

Copy link
Member

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit that fixed showing the image. LGTM now. Thanks again!

Copy link
Member

@TMRh20 TMRh20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@2bndy5 2bndy5 merged commit d213bbf into nRF24:master Feb 11, 2025
6 checks passed
2bndy5 added a commit that referenced this pull request Feb 11, 2025
@2bndy5
Copy link
Member

2bndy5 commented Feb 11, 2025

changes are live! 🎉

I also cherry picked this patch to v1.x branch 😉

@epsi1on
Copy link
Contributor Author

epsi1on commented Feb 12, 2025

Thanks all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants