-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow render non-visual nodes that signalise slot is ready. #562
Merged
blackrabbit99
merged 1 commit into
master
from
feature/force-transition-blocker-removal
Nov 29, 2023
Merged
feat: allow render non-visual nodes that signalise slot is ready. #562
blackrabbit99
merged 1 commit into
master
from
feature/force-transition-blocker-removal
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage ReportIlc/serverCommit SHA:ad0da832cec3b8bfdaf57175cb5575c41c49790f Test coverage results 🧪
File details
Ilc/clientCommit SHA:ad0da832cec3b8bfdaf57175cb5575c41c49790f Test coverage results 🧪
File details
RegistryCommit SHA:ad0da832cec3b8bfdaf57175cb5575c41c49790f Test coverage results 🧪
File details
|
stas-nc
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ILC could have a case when slot is a part of template but because of persistent state it render nothing. It that case blocker is not removed because MutationObserver waits for the visual change not a regular mutation. So proposal is allow to use a special element that signalise that slot blocker could be removed.