-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve root namespace for vxproj files #3089
Conversation
- Fix condition to skip mscorlib unit tests when not PR. ***NO_CI***
WalkthroughThe changes update the RootNamespace property in four project files (.vcxproj). Each file’s previous value of "Windows.Storage" is replaced with a nanoFramework-specific namespace that indicates a shift in the module’s framework affiliation. No other modifications were made to the project configurations, item groups, or file structures. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/DeviceInterfaces/System.Net/System.Net.vcxproj (1)
40-40
: Consider aligning namespace with directory structure.The namespace
nanoFramework.Networking
doesn't match the project's directory nameSystem.Net
. For consistency with other projects and to avoid confusion, consider usingnanoFramework.System.Net
instead.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/DeviceInterfaces/Networking.Sntp/Networking.Sntp.vcxproj
(1 hunks)src/DeviceInterfaces/System.Net/System.Net.vcxproj
(1 hunks)src/System.Device.Gpio/System.Device.Gpio.vcxproj
(1 hunks)src/System.IO.Ports/System.IO.Ports.vcxproj
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: nf-interpreter (Nightly build) (Build_STM32_targets ST_NUCLEO64_F091RC)
- GitHub Check: nf-interpreter (Nightly build) (Build_STM32_targets ORGPAL_PALX)
- GitHub Check: nf-interpreter (Nightly build) (Build_STM32_targets ORGPAL_PALTHREE)
- GitHub Check: nf-interpreter (Nightly build) (Check_Build_Options)
🔇 Additional comments (3)
src/System.IO.Ports/System.IO.Ports.vcxproj (1)
31-31
: LGTM! Namespace change aligns with project structure.The new namespace
nanoFramework.System.IO.Ports
correctly reflects the project's directory structure and purpose.src/DeviceInterfaces/Networking.Sntp/Networking.Sntp.vcxproj (1)
31-31
: LGTM! Namespace change aligns with project structure.The new namespace
nanoFramework.Networking.Sntp
correctly reflects the project's directory structure and purpose.src/System.Device.Gpio/System.Device.Gpio.vcxproj (1)
32-32
: LGTM! Namespace change aligns with project structure.The new namespace
nanoFramework.System.Device.Gpio
correctly reflects the project's directory structure and purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Thank you. 👍🏻
Description
Fixes the root VS CPP project namespaces used when creating new source files in VC++ project.
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist
Summary by CodeRabbit