-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[github-nfbot] Revert back to .NET 6 #89
Conversation
WalkthroughThe pull request modifies the GitHub Actions workflow configuration for the NanoFramework GitHubBot. The primary changes involve downgrading the .NET version from 8.0.x to 6.0.x and updating the build command's output specification. The workflow's core structure remains unchanged, with adjustments focused on the build environment and artifact generation process. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
.github/workflows/NanoFramework-GitHubBot.yml (2)
37-37
: LGTM! Monitor the deploymentThe switch to
--output
is a good change as it's the recommended approach for specifying the output directory. Please monitor the first deployment to ensure the Azure Function App receives the artifacts correctly.Consider adding a post-deployment verification step to the workflow to confirm the function is running correctly with .NET 6.
Line range hint
1-46
: Document .NET 8 issues and plan future upgrade strategyWhile reverting to .NET 6 addresses immediate issues, consider:
- Document the specific issues encountered with .NET 8
- Create tracking issues for investigating and resolving these problems
- Plan a future upgrade path back to .NET 8 or newer
Would you like me to help create GitHub issues to track these tasks?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
github-nfbot/GitHub-nfbot/GitHub-nfbot.csproj
is excluded by none and included by none
📒 Files selected for processing (1)
.github/workflows/NanoFramework-GitHubBot.yml
(2 hunks)
🔇 Additional comments (1)
.github/workflows/NanoFramework-GitHubBot.yml (1)
18-18
: Verify .NET 6 compatibility across the codebase
The downgrade to .NET 6 aligns with the PR objectives. However, we should verify:
- All NuGet package dependencies are compatible with .NET 6
- No .NET 8 specific features are being used in the codebase
Most likely this is because of the running environment on the Azure Function VM. If we are updating it, we have to go all the way. |
Description
There were issues with using .NET 8 that need to be solved. This is a rollback to the known working version.
Motivation and Context
Rollback strategy.
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Summary by CodeRabbit