Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github-nfbot] Revert back to .NET 6 #89

Merged
merged 1 commit into from
Dec 15, 2024
Merged

[github-nfbot] Revert back to .NET 6 #89

merged 1 commit into from
Dec 15, 2024

Conversation

networkfusion
Copy link
Member

@networkfusion networkfusion commented Dec 15, 2024

Description

There were issues with using .NET 8 that need to be solved. This is a rollback to the known working version.

Motivation and Context

Rollback strategy.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

Summary by CodeRabbit

  • Chores
    • Updated the .NET version used in the build process.
    • Modified the command for building Azure Functions to change the output directory specification.

Copy link

coderabbitai bot commented Dec 15, 2024

Walkthrough

The pull request modifies the GitHub Actions workflow configuration for the NanoFramework GitHubBot. The primary changes involve downgrading the .NET version from 8.0.x to 6.0.x and updating the build command's output specification. The workflow's core structure remains unchanged, with adjustments focused on the build environment and artifact generation process.

Changes

File Change Summary
.github/workflows/NanoFramework-GitHubBot.yml - Updated DOTNET_VERSION from '8.0.x' to '6.0.x'
- Replaced --property:PublishDir with --output for Azure Function build command

Possibly related PRs

Suggested labels

Area: Config-and-Build

Suggested reviewers

  • josesimoes

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. This feature will be included in our Pro Plan when released.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
.github/workflows/NanoFramework-GitHubBot.yml (2)

37-37: LGTM! Monitor the deployment

The switch to --output is a good change as it's the recommended approach for specifying the output directory. Please monitor the first deployment to ensure the Azure Function App receives the artifacts correctly.

Consider adding a post-deployment verification step to the workflow to confirm the function is running correctly with .NET 6.


Line range hint 1-46: Document .NET 8 issues and plan future upgrade strategy

While reverting to .NET 6 addresses immediate issues, consider:

  1. Document the specific issues encountered with .NET 8
  2. Create tracking issues for investigating and resolving these problems
  3. Plan a future upgrade path back to .NET 8 or newer

Would you like me to help create GitHub issues to track these tasks?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7787d96 and d30f2d2.

⛔ Files ignored due to path filters (1)
  • github-nfbot/GitHub-nfbot/GitHub-nfbot.csproj is excluded by none and included by none
📒 Files selected for processing (1)
  • .github/workflows/NanoFramework-GitHubBot.yml (2 hunks)
🔇 Additional comments (1)
.github/workflows/NanoFramework-GitHubBot.yml (1)

18-18: Verify .NET 6 compatibility across the codebase

The downgrade to .NET 6 aligns with the PR objectives. However, we should verify:

  1. All NuGet package dependencies are compatible with .NET 6
  2. No .NET 8 specific features are being used in the codebase

@networkfusion networkfusion merged commit d08179f into main Dec 15, 2024
5 checks passed
@networkfusion networkfusion deleted the revert-net6 branch December 15, 2024 00:10
@coderabbitai coderabbitai bot mentioned this pull request Dec 15, 2024
14 tasks
@josesimoes
Copy link
Member

Most likely this is because of the running environment on the Azure Function VM. If we are updating it, we have to go all the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants