Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CI tests #213

Closed
GenevieveBuckley opened this issue May 24, 2024 · 0 comments
Closed

Fix failing CI tests #213

GenevieveBuckley opened this issue May 24, 2024 · 0 comments

Comments

@GenevieveBuckley
Copy link
Contributor

GenevieveBuckley commented May 24, 2024

The CI tests are currently failing.

Problem description

See here for an example: https://github.com/napari/napari-animation/actions/runs/9218650940

The reason for this failure is that imageio-ffmpeg does not include the FFMPEG binary for Apple Silicon Macs (see issue here imageio/imageio-ffmpeg#71). Since the github actions runners recently switched over so that macos-latest runs on Apple Silicon. That means we now get an error that imageio-ffmpeg cannot find the FFMPEG executable.

Proposed solution

Update the github actions workflow to check if it is running on Mac, and if it is then brew install ffmpeg (with this github action. We can link to imageio/imageio-ffmpeg#71, and note this is a temporary workaround that can be removed when imageio-ffmpeg releases a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants