-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install FFMPEG with brew on Mac CI runners #214
Conversation
Sphinx docs
Temporary fix for issue imageio/imageio-ffmpeg#71
The ruff CI check failed earlier because I updated ruff's target version of python from 3.8 to 3.12. To keep things simple, I've reverted that change here for now, and made a separate PR to update ruff #218. |
Thanks for taking a look at this! The pyside changes (at a minimum) from here: Also, to echo Grzegorz's question, why not use the homebrew installed on the macOS runners? The other option/alternative PR is to switch to macOS-13 instead of latest (the x86 runners). |
I saw several brew actions available on the github marketplace, and assumed that meant the default runners did not come with it already installed. |
I'm going to close this - even though I've removed the marketplace github action (and this is change can be seen in the workflow file), the action is still being run on the CI jobs. It's probably easiest to delete this, instead of figuring out if there is a cache somewhere. |
Superseded by #222 |
Closes #213
This is a temporary fix for issue imageio/imageio-ffmpeg#71, which has been causing our CI to fail.