-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUMULUS-3856 Update cumulus-api document #360
Conversation
@jennyhliu Thanks for the feedback, I will review and make code updates |
one I think you might have missed: https://nasa.github.io/cumulus-api/unreleased/#migration-counts |
Sorry to jump into this late, I wanted to look into this and provide some feedback but was focused on my other ticket. My one suggestion for now is to update the description for prefix and infix in the table in the intro. Because we're switching from ES to PG style queries, these queries don't quite have the same functionality. And if you do a search for infix and prefix in the core code for the feature branch, we are generally just using |
I removed the Migration Counts section. |
@charleshuang80 I am looking through the code in the |
@jennyhliu @Nnaga1 @charleshuang80 I have implemented the feedback that I have received on this PR. Can you review again? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Addresses issues in CUMULUS-3856