-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nasa/nos3#466] Generic Magnetometer Checkout #495
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #495 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 2 2
=====================================
Misses 2 2 ☔ View full report in Codecov by Sentry. |
@dacarter22 couple minor things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. But, you should change the shortcut for generic_mag over to 'm', instead of 's', since it isn't sample. Also config as a variable is unused without the config command, so you can remove it so that the compiler doesn't send warnings. Other than that seems good.
Did a bunch of spot fixes, big highlights:
The core is there, but there are little things that need to get cleaned up in the end, and they are important to understand. Have verified my changes work in checkout mode and in cFS with YAMCS. |
Pull Request for generic_mag
Standard make prep;make with sc-minimal-config
cmake .. -DTGTNAME=cpu1 in fsw/standalone/build then make clean;make
Uncomment Mag Sim code in checkout.sh
make checkout
Closes #466