Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#466] Generic Magnetometer Checkout #495

Merged
merged 10 commits into from
Feb 14, 2025

Conversation

dacarter22
Copy link
Contributor

@dacarter22 dacarter22 commented Feb 6, 2025

Pull Request for generic_mag

Standard make prep;make with sc-minimal-config
cmake .. -DTGTNAME=cpu1 in fsw/standalone/build then make clean;make
Uncomment Mag Sim code in checkout.sh
make checkout

Closes #466

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (acae0f5) to head (6d90021).
Report is 50 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #495   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines          2       2           
=====================================
  Misses         2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlucas9
Copy link
Contributor

jlucas9 commented Feb 8, 2025

@dacarter22 couple minor things:

  • Received data in the checkout is not printed out so can't manually compare from sim that is was successful
  • Noop in checkout doesn't function

@jlucas9 jlucas9 changed the title Nos3#466 generic mag checkout application [nasa/nos3#466] Generic Magnetometer Checkout Feb 8, 2025
Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. But, you should change the shortcut for generic_mag over to 'm', instead of 's', since it isn't sample. Also config as a variable is unused without the config command, so you can remove it so that the compiler doesn't send warnings. Other than that seems good.

@kevincbruce
Copy link
Contributor

kevincbruce commented Feb 14, 2025

Did a bunch of spot fixes, big highlights:

  • Remember, you need to delete device files from src, delete the support folder if it exists (old checkout), and add the proper lines to the cmake. They were missing again, and I had to add them. This is why it was not working with cFS unless you had them in src. Updates don't work if CMAKE isn't looking in the right place when building.
  • XTCE was missing. This has been an issue with several branches, including ones I've made. Not sure if it is some weird git issue, or something else, but it showed up in the pointer dev was pointing at, but not in dev when I pulled it in the mag component. Should be looked into. This is why YAMCS wasn't launching.
  • Minor naming things. If a variable is no longer used and it warns you about it in GCC, delete it. If you are making a checkout for a new app, change the shorthand commands (in this case the 's' for sample data, to something that makes sense for your new app ('m' for magnetometer, 'd' for data. I went with 'm' to be consistent with other checkouts

The core is there, but there are little things that need to get cleaned up in the end, and they are important to understand.

Have verified my changes work in checkout mode and in cFS with YAMCS.

@kevincbruce kevincbruce merged commit 7b68427 into dev Feb 14, 2025
3 checks passed
@kevincbruce kevincbruce deleted the nos3#466-generic-mag-checkout-application branch February 14, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants