-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nasa/nos3#465] generic imu checkout application #506
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #506 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 2 2
=====================================
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some final cleanup fixes, here are the highlights:
- readded xtce, was missing here too. Not sure why, don't think it is your fault, seems to be a weird thing across the board
- fixed some naming things. consistent capitalization, short command name consistent with actual command for data, etc
- removed config command and variable, as it was unused by this point. Best we not leave unused commands in.
Also did some minor fixes to the checkout.sh file, just fixing some seeming merge errors (though there may be something I missed), and commenting out the IMU checkout stuff so it is ready to merge. Looks good otherwise. Is just small things, just need to be vigilant.
Proper instructions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I go to make, the inconsistent capitalization in the checkout breaks things; once that is fixed, I think everything is in order to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, and I can confirm that it runs properly.
Verified that app.c simulator works with make launch even after removing CFE_PSP functions.
To test checkout
sc-minimal-config
make clean
make debug
cd components/generic_imu/fsw/standalone/build
(mkdir build in the standalone directory if needed, then cd build)
make clean (if build directory already exists)
cmake .. -DTGTNAME=cpu1
make
exit
make clean
make
make checkout
To test simulator
from root nos3 directory
make clean
make
make launch