Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#465] generic imu checkout application #506

Merged
merged 13 commits into from
Feb 14, 2025

Conversation

dacarter22
Copy link
Contributor

@dacarter22 dacarter22 commented Feb 13, 2025

Verified that app.c simulator works with make launch even after removing CFE_PSP functions.

To test checkout

sc-minimal-config
make clean
make debug
cd components/generic_imu/fsw/standalone/build
(mkdir build in the standalone directory if needed, then cd build)
make clean (if build directory already exists)
cmake .. -DTGTNAME=cpu1
make
exit
make clean
make
make checkout

To test simulator
from root nos3 directory
make clean
make
make launch

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (acae0f5) to head (62c1e6f).
Report is 61 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #506   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines          2       2           
=====================================
  Misses         2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevincbruce kevincbruce self-requested a review February 14, 2025 19:58
Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some final cleanup fixes, here are the highlights:

  • readded xtce, was missing here too. Not sure why, don't think it is your fault, seems to be a weird thing across the board
  • fixed some naming things. consistent capitalization, short command name consistent with actual command for data, etc
  • removed config command and variable, as it was unused by this point. Best we not leave unused commands in.

Also did some minor fixes to the checkout.sh file, just fixing some seeming merge errors (though there may be something I missed), and commenting out the IMU checkout stuff so it is ready to merge. Looks good otherwise. Is just small things, just need to be vigilant.

@kevincbruce
Copy link
Contributor

Proper instructions:

make clean
make debug
cd components/generic_imu/fsw/standalone/build
(mkdir build in the standalone directory if needed, then cd build)
make clean (if build directory already exists)
cmake .. -DTGTNAME=cpu1
make
exit
make clean
make
make checkout

Copy link
Contributor

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I go to make, the inconsistent capitalization in the checkout breaks things; once that is fixed, I think everything is in order to merge.

@kevincbruce kevincbruce changed the title Nos3#465 generic imu checkout application [nasa/nos3#465] generic imu checkout application Feb 14, 2025
Copy link
Contributor

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, and I can confirm that it runs properly.

@kevincbruce kevincbruce merged commit 0be37bf into dev Feb 14, 2025
3 checks passed
@kevincbruce kevincbruce deleted the nos3#465-generic-imu-checkout-application branch February 14, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants