-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nasa/nos3#417] Support for Mac M1/M2 #508
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #508 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 2 2
=====================================
Misses 2 2 ☔ View full report in Codecov by Sentry. |
I don't own any Macs, so don't think I can test myself. |
Can you test on your Windows machine to confirm it doesn't bork that? |
I can check on my mac, one second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed still working on windows.
Still works on Windows. May test on ARM64 Linux later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works the same for me on the regular NOS3 VM as does the development branch, so approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mac vagrant really doesn't like virtioscsi disk controller but other than that runs fine on my mac M1 Pro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #417
Must close and merge / release docker container for the following: