Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#417] Support for Mac M1/M2 #508

Merged
merged 5 commits into from
Feb 19, 2025
Merged

[nasa/nos3#417] Support for Mac M1/M2 #508

merged 5 commits into from
Feb 19, 2025

Conversation

jlucas9
Copy link
Contributor

@jlucas9 jlucas9 commented Feb 14, 2025

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (acae0f5) to head (8bfe70e).
Report is 75 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #508   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines          2       2           
=====================================
  Misses         2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlucas9
Copy link
Contributor Author

jlucas9 commented Feb 14, 2025

Confirmed working on Mac M2! CryptoLib and sun pointing confirmed:

5380F633-8315-447F-AADB-481602727003

@kevincbruce
Copy link
Contributor

I don't own any Macs, so don't think I can test myself.

@jlucas9
Copy link
Contributor Author

jlucas9 commented Feb 14, 2025

I don't own any Macs, so don't think I can test myself.

Can you test on your Windows machine to confirm it doesn't bork that?

@dacarter22
Copy link
Contributor

I can check on my mac, one second

Copy link
Contributor

@Donnie-Ice Donnie-Ice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed still working on windows.

@kevincbruce
Copy link
Contributor

Still works on Windows. May test on ARM64 Linux later.

Copy link
Contributor

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works the same for me on the regular NOS3 VM as does the development branch, so approving.

Copy link
Contributor

@dacarter22 dacarter22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac vagrant really doesn't like virtioscsi disk controller but other than that runs fine on my mac M1 Pro

Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of this issue with YAMCS linking with the networks, everything seems to launch as expected on my Pi5, so seems to just generally work on ARM64, minus configuration/deployment challenges:
Screenshot from 2025-02-18 21-48-17

@jlucas9 jlucas9 merged commit 59b464a into dev Feb 19, 2025
3 checks passed
@jlucas9 jlucas9 deleted the nos3#417 branch February 19, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants