Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#434] Release Candidate 1.7.2 #509

Merged
merged 15 commits into from
Feb 23, 2025
Merged

[nasa/nos3#434] Release Candidate 1.7.2 #509

merged 15 commits into from
Feb 23, 2025

Conversation

jlucas9
Copy link
Contributor

@jlucas9 jlucas9 commented Feb 19, 2025

Closes #434

Recommended Testing RC 1.7.2

Note that this is the recommended. Please explore and ensure other use cases you typically see are also covered!

Provisioned Tests

Need to run all tests with the following provisioning permutations:

  • Freshly provisioned VM via vagrant
    • Default pathing provided
    • Different shared folder path
  • Direct clone into a self provisioned Ubuntu environment

Configuration Tests

Default

  • No change to ./cfg/nos3-mission.xml, defaults are cFS and YAMCS
  • Confirm
    • Flight software loaded and running successfully
    • Spacecraft in 42 GUI points at sun and telemetry reports SVB (sun vector in body frame) X gets to a value of 1, others 0
  • Show CryptoLib tab, run tc, send a CFE_ES_NOOP and confirm clear mode, run vcid 2, send CFE_ES_NOOP and confirm encrypted, run vcid 1, send CFE_ES_NOOOP and confirm clear again

COSMOS

  • Change ./cfg/nos3-mission.xml to COSMOS as the GSW
  • Organize windows and start "COSMOS" from the NOS3 Launcher
  • Open "Telemetry Grapher" with ./gsw/cosmos/config/tools/tlm_grapher/generic_adcs.txt
  • Confirm
    • Flight software loaded and running successfully
    • Spacecraft in 42 GUI points at sun and telemetry grapher gets to SVB (sun vector in body frame) X gets to a value of 1, others 0
  • Open "Test Runner" and click "Start" next to Mission_Test and wait for success
  • Show CryptoLib tab, run tc, send a CFE_ES_NOOP and confirm clear mode, run vcid 2, send CFE_ES_NOOP and confirm encrypted, run vcid 1, send CFE_ES_NOOOP and confirm clear again
  • In "Test Runner" run the "Start" for Mission_Test again and wait for success

F'

  • Change ./cfg/nos3-mission.xml to FSW / GSW both to fprime and use sc-fprime-config.xml
  • Confirm
    • sampleSim.NOOP command and see it in sim
    • sampleSim.REQUEST_HOUSEKEEPING command, see it in sim, and see it in F' GDS event telemetry
    • generic_radio.REQUEST_HOUSEKEEPING command, see it in sim, and see it in F' GDS event telemetry
    • generic_star_tracker.NOOP command and see it in sim
    • generic_star_tracker.REQUEST_HOUSEKEEPING command, see it in sim, and see it in F' GDS event telemetry

Test Checklist for Reviewers

  • Provisioned default path
    • Default
    • COSMOS
    • F'
  • Provisioned custom path
    • Default
    • COSMOS
    • F'
  • Direct clone into Linux
    • Default
    • COSMOS
    • F'
  • Documentation reviewed

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (acae0f5) to head (261576b).
Report is 81 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #509   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines          2       2           
=====================================
  Misses         2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working on default provisioning, local on provisioned VM, and in my own Ubuntu system.

Test Checklist for Reviewers

  • Provisioned default path
    • Default
    • COSMOS
    • F' - worked with dos2unix fix
  • Custom Local on Provisioned VM
    • Default
    • COSMOS
    • F'
  • Direct clone into Linux
    • Default
    • COSMOS
    • F'
  • Documentation reviewed

Additional Notes:

  • VM (at least pre-guest additions upgrade) has a slightly broken version of our theme. Dock existed, and performance metrics weren't actually right aligned, and the icons spawned in weird places on desktop (weirder than normal)
  • F' in Shared Folder didn't work. Sent screenshot to Zach. Can post here as well if desired
  • COSMOS didn't connect its server the first time with shared folder. After a make uninstall it worked. Will have to test with just a make clean. But the first make clean & make cycle when switching from YAMCS to COSMOS seemed to have the same problem for me both when I tried dev and the release branch.
  • Couldn't verify TLM for Star Tracker in F'. Verified Sim got it and seemed to reply, but didn't see TLM points in F'. Not entirely sure how that works though.

Actions/Issues:

  • YAMCS has only On/Off Toggle for ADCS Set Mode, while it should have multiple states. This means sun pointing manually is currently impossible in YAMCS. YAMCS ADCS Set Mode Command On/Off Rather than States in XTCE #511 - Verified Fixed

  • Not for this release, but created an issue to look at an alternative to gnome-terminal for launching things, so that we can have wider compatibility with different Linux desktop environments, and environments on Mac or Windows Subsystem for Linux. As, even after installing gnome-terminal on MATE (lightdm), it would spawn all the windows and work correctly, but everything would be separate windows rather than tabs unless I switched to Gnome3 or Gnome Classic. Find an Alternative to gnome-terminal that can work with more desktop environments #513

Will continue to update this thread as I test. Only thing I have left to do is the shared folder with a different path.

@szemerick
Copy link

szemerick commented Feb 20, 2025

Zemerick Test Checklist and Notes

updated vagrant from 2.4.1 to 2.4.3 in order for vagrant to "see" my installed VirtualBox.
the github-nos3 folder was empty. The shared folder was mounted to /media/sf_home_jstar_Desktop_github-nos3. > >Continuing to work from this mounted folder.
This is how the share shows up in the VB GUI:
home_jstar_Desktop_github-nos3

Default Configuration: after running make | make launch, cFS starts, 42, simulators all work

Firefox was launched, but the page "localhost:8090" does not load. It says "The connection was reset"
Reloading the page brought up yamcs. Can we delay opening firefox until yamcs server is up?
The "connection reset" error was ugh.

CryptoLib Checked Out
COSMOS tlm grapher of ACS data works
COSMOS Mission Test Passed
With COSMOS, checked out cryptolib, but did not see packets like I did with Yamcs.

RESOLVED. I forgot to use the Radio interface for this COSMOS/CryptoLib test**

Provisioned default path

  • Default
  • COSMOS
  • F'

Provisioned custom path

  • Default
  • COSMOS
  • F'

Direct clone into Linux

  • Default
  • COSMOS
  • F'

Copy link
Contributor

@msuder msuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable to me.

@msuder
Copy link
Contributor

msuder commented Feb 20, 2025

  • Provisioned default path
    • Default
    • COSMOS
    • F'
  • Provisioned custom path
    • Default
    • COSMOS
    • F'
  • Direct clone into Linux
    • Default
    • COSMOS
    • F'
  • Documentation reviewed

@zlynch2
Copy link
Contributor

zlynch2 commented Feb 20, 2025

adding the dos2unix command to documentation common questions.

find . -type f -print0 | xargs -0 dos2unix

The above finds all files and removes windows line endings (\r). This is run in nos3/

#512

This was fixed commit pushed, updated home.md to reflect above. when RC merges to dev 512 will close

Copy link
Contributor

@Donnie-Ice Donnie-Ice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Checklist for Reviewers

  • Provisioned default path
    • Default
    • COSMOS
    • F'
  • Custom Local on Provisioned VM
    • Default
    • COSMOS
    • F'
  • Direct clone into Linux
    • Default
    • COSMOS
    • F'
  • Documentation reviewed

Copy link
Contributor

@zlynch2 zlynch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provisioned default path

  • Default
  • COSMOS
  • F'

Provisioned custom path

  • Default
  • COSMOS
  • F'

Direct clone into Linux

  • Default

  • COSMOS

  • F'

  • Documentation reviewed

Reviewed documentation, updated obvious things. tested above. Was able to build and run according to instructions. Approving based on current state of branch. Dos2unix was the only major test case but added how to convert in the documentation FAQs, F' was able to build after running dos2unix.

@zlynch2
Copy link
Contributor

zlynch2 commented Feb 21, 2025

Updating docs issue created: #514

changing from fsw/nos3_defs to cfg/nos3_defs

@rjbrown2
Copy link
Member

Recent Commit closes #511

@rjbrown2
Copy link
Member

rjbrown2 commented Feb 21, 2025

  • Provisioned default path
    • Default
    • COSMOS
    • F'
  • Provisioned custom path
    • Default
    • COSMOS
    • F'
  • Direct clone into Linux
    • Default
    • COSMOS
    • F'
  • Documentation reviewed

Copy link
Contributor

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Provisioned default path
    • Default
    • COSMOS
    • F'
  • Provisioned custom path
    • Default
    • COSMOS
    • F'
  • Direct clone into Linux
    • Default
    • COSMOS
    • F'
  • Documentation reviewed

@jlucas9 jlucas9 merged commit 4f13a11 into dev Feb 23, 2025
3 checks passed
@jlucas9 jlucas9 deleted the nos3#434-rc1.7.2 branch February 23, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants