-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nasa/nos3#434] Release Candidate 1.7.2 #509
Conversation
…nsion into the design reference mission / ConOps;
…g. adding to top level nos
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #509 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 2 2
=====================================
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working on default provisioning, local on provisioned VM, and in my own Ubuntu system.
Test Checklist for Reviewers
- Provisioned default path
- Default
- COSMOS
- F' - worked with dos2unix fix
- Custom Local on Provisioned VM
- Default
- COSMOS
- F'
- Direct clone into Linux
- Default
- COSMOS
- F'
- Documentation reviewed
Additional Notes:
- VM (at least pre-guest additions upgrade) has a slightly broken version of our theme. Dock existed, and performance metrics weren't actually right aligned, and the icons spawned in weird places on desktop (weirder than normal)
- F' in Shared Folder didn't work. Sent screenshot to Zach. Can post here as well if desired
- COSMOS didn't connect its server the first time with shared folder. After a make uninstall it worked. Will have to test with just a make clean. But the first
make clean & make
cycle when switching from YAMCS to COSMOS seemed to have the same problem for me both when I tried dev and the release branch. - Couldn't verify TLM for Star Tracker in F'. Verified Sim got it and seemed to reply, but didn't see TLM points in F'. Not entirely sure how that works though.
Actions/Issues:
-
YAMCS has only On/Off Toggle for ADCS Set Mode, while it should have multiple states. This means sun pointing manually is currently impossible in YAMCS. YAMCS ADCS Set Mode Command On/Off Rather than States in XTCE #511- Verified Fixed -
Not for this release, but created an issue to look at an alternative to gnome-terminal for launching things, so that we can have wider compatibility with different Linux desktop environments, and environments on Mac or Windows Subsystem for Linux. As, even after installing gnome-terminal on MATE (lightdm), it would spawn all the windows and work correctly, but everything would be separate windows rather than tabs unless I switched to Gnome3 or Gnome Classic. Find an Alternative to gnome-terminal that can work with more desktop environments #513
Will continue to update this thread as I test. Only thing I have left to do is the shared folder with a different path.
Zemerick Test Checklist and Notes
Provisioned default path
Provisioned custom path
Direct clone into Linux
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look reasonable to me.
|
adding the dos2unix command to documentation common questions. find . -type f -print0 | xargs -0 dos2unix The above finds all files and removes windows line endings (\r). This is run in nos3/ This was fixed commit pushed, updated home.md to reflect above. when RC merges to dev 512 will close |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Checklist for Reviewers
- Provisioned default path
- Default
- COSMOS
- F'
- Custom Local on Provisioned VM
- Default
- COSMOS
- F'
- Direct clone into Linux
- Default
- COSMOS
- F'
- Documentation reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provisioned default path
- Default
- COSMOS
- F'
Provisioned custom path
- Default
- COSMOS
- F'
Direct clone into Linux
-
Default
-
COSMOS
-
F'
-
Documentation reviewed
Reviewed documentation, updated obvious things. tested above. Was able to build and run according to instructions. Approving based on current state of branch. Dos2unix was the only major test case but added how to convert in the documentation FAQs, F' was able to build after running dos2unix.
Updating docs issue created: #514 changing from fsw/nos3_defs to cfg/nos3_defs |
Recent Commit closes #511 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Provisioned default path
- Default
- COSMOS
- F'
- Provisioned custom path
- Default
- COSMOS
- F'
- Direct clone into Linux
- Default
- COSMOS
- F'
- Documentation reviewed
Closes #434
Recommended Testing RC 1.7.2
Note that this is the recommended. Please explore and ensure other use cases you typically see are also covered!
Provisioned Tests
Need to run all tests with the following provisioning permutations:
Configuration Tests
Default
./cfg/nos3-mission.xml
, defaults are cFS and YAMCStc
, send a CFE_ES_NOOP and confirm clear mode, runvcid 2
, send CFE_ES_NOOP and confirm encrypted, runvcid 1
, send CFE_ES_NOOOP and confirm clear againCOSMOS
./cfg/nos3-mission.xml
to COSMOS as the GSW./gsw/cosmos/config/tools/tlm_grapher/generic_adcs.txt
tc
, send a CFE_ES_NOOP and confirm clear mode, runvcid 2
, send CFE_ES_NOOP and confirm encrypted, runvcid 1
, send CFE_ES_NOOOP and confirm clear againF'
./cfg/nos3-mission.xml
to FSW / GSW both to fprime and use sc-fprime-config.xmlTest Checklist for Reviewers