Added find/replace box #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natenho
requested changes
Nov 29, 2018
There was a problem hiding this comment.
@eduardosoprani , I added some comments to your code, hope it helps. Thank you for your contribution!
| public SessionForm() | ||
| { | ||
| InitializeComponent(); | ||
|
|
||
| myFindReplace = new FindReplace(editor); // For WinForms |
There was a problem hiding this comment.
Clean code tips:
- Consider removing "my" prefix from the variable name, because it doesn't add value to the name, it's just noise. In this particular case, follow the convention and use "_findReplace".
- Remove the comment. It doesn't add any value to the code.
| } | ||
| else if (e.Control && e.KeyCode == Keys.G) | ||
| { | ||
| GoTo MyGoTo = new GoTo((ScintillaNET.Scintilla)sender); |
There was a problem hiding this comment.
Please review variable naming, remove the prefix "My" and use camel Case for local variables: "goTo" in this case.
| @@ -51,6 +51,9 @@ | |||
| <Reference Include="Newtonsoft.Json, Version=11.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL"> | |||
| <HintPath>..\..\packages\Newtonsoft.Json.11.0.2\lib\net45\Newtonsoft.Json.dll</HintPath> | |||
| </Reference> | |||
| <Reference Include="ScintillaNET FindReplaceDialog"> | |||
| <HintPath>..\..\..\ScintillaNET-FindReplaceDialog\ScintillaNet FindReplaceDialog\bin\Release\ScintillaNET FindReplaceDialog.dll</HintPath> | |||
There was a problem hiding this comment.
Please fix this :)
I can't merge your pull request because the build is broken by this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.