Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refinements to MSG TTL spec during implementation #315

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ripienaar
Copy link
Contributor

No description provided.

@ripienaar
Copy link
Contributor Author

I think this is the only deviations so far? But please let me know about others and once you are done implementing we can merge this with all the changes included

adr/ADR-43.md Show resolved Hide resolved
@ripienaar ripienaar marked this pull request as ready for review January 9, 2025 10:55
adr/ADR-43.md Outdated Show resolved Hide resolved
@neilalexander
Copy link
Member

Notes:

  • Keep reject on Nats-TTL with TTLs disabled for client publishes, but allow keeping the header via sources/mirrors, just ignore them
  • Ensure LimitsTTL cannot be enabled at the same time as mirroring
  • Future option to remove individual headers on a per-source/mirror basis to remove TTLs later if we want

@ripienaar
Copy link
Contributor Author

OK, so to summarise where we got to, would this be your understanding @neilalexander :

  • We will accept Nats-TTL over sources/mirrors always and leave it as is
  • If the Source has ttl handling enabled we will process it
  • Mirrors may not enable that setting

right?

@neilalexander
Copy link
Member

As it stands, AllowMsgTTL can be enabled on a mirror but LimitsTTL cannot be. Otherwise yep, that's right.

@ripienaar
Copy link
Contributor Author

As it stands, AllowMsgTTL can be enabled on a mirror but LimitsTTL cannot be. Otherwise yep, that's right.

updated with bd022dc to capture these

adr/ADR-43.md Outdated Show resolved Hide resolved
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants