Legg til arbiedsgiverkort #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red-by: Joar Aurdal <[email protected]>’
Co-authored-by: Vilde Stefferud <[email protected]>
Co-authored-by: Joar Aurdal <[email protected]>
Co-authored-by: Vilde Stefferud <[email protected]>
Co-authored-by: Joar Aurdal <[email protected]>
Co-authored-by: Vilde Stefferud <[email protected]>
Co-authored-by: Vilde Stefferud <[email protected]>
Co-authored-by: Vilde Stefferud <[email protected]>
Co-authored-by: Vilde Stefferud <[email protected]>
Co-authored-by: Joar Aurdal <[email protected]>
Co-authored-by: Vilde Stefferud <[email protected]>
Co-authored-by: Joar Aurdal <[email protected]>
Co-authored-by: Joar Aurdal <[email protected]>
Co-authored-by: Vilde Stefferud <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new employer card feature to the rekrutteringstreff application, allowing users to add and display employers associated with an event. Key changes include:
- Addition of new components (Arbeidsgivere, LeggTilArbeidsgiverModal, and updates to RekrutteringstreffDetaljerKort) to handle employer listing and creation.
- Implementation of new API hooks and endpoints (useRekrutteringstreffArbeidsgivere and leggtilNyArbeidsgiver) with corresponding Mirage mocks.
- Integration of the new employer functionality into the overall tab-based layout for rekrutteringstreff.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/rekrutteringstreff/[rekrutteringstreffId]/components/arbeidsgivere/Arbeidsgivere.tsx | New component for displaying a list of employers. |
| app/rekrutteringstreff/[rekrutteringstreffId]/components/LeggTilArbeidsgiverModal.tsx | New modal component for adding an employer. |
| app/rekrutteringstreff/[rekrutteringstreffId]/RekrutteringstreffContext.tsx | Context provider updates to support employer operations. |
| app/rekrutteringstreff/[rekrutteringstreffId]/components/om-treffet/OmTreffet.tsx | Minor updates integrating employer-related UI. |
| app/api/rekrutteringstreff/[...slug]/useArbeidsgivere.tsx | New hook for fetching employers with an endpoint issue. |
| app/api/rekrutteringstreff/[...slug]/ny-arbeidsgiver/leggTilNyArbeidsgiver.ts | Endpoint and API call updates for adding a new employer. |
| app/rekrutteringstreff/[rekrutteringstreffId]/components/RekrutteringstreffDetaljerKort.tsx | Updated card UI to include the new LeggTilArbeidsgiverModal. |
| app/rekrutteringstreff/[rekrutteringstreffId]/Rekrutteringstreff.tsx | Updated tabbed interface to incorporate employer functionality. |
| mocks/* | Updates to Mirage mocks to support the new API endpoints. |
Comment on lines
+13
to
+14
| `${RekrutteringstreffAPI.internUrl}/${id}/arbeidsgivere}`; | ||
|
|
There was a problem hiding this comment.
The endpoint string has an extra closing brace. It should be corrected to remove the trailing '}' to correctly form the URL.
Suggested change
| `${RekrutteringstreffAPI.internUrl}/${id}/arbeidsgivere}`; | |
| `${RekrutteringstreffAPI.internUrl}/${id}/arbeidsgivere`; |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.