Add basic specs for Onfleet objects #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubocop: Layout/DotPosition
rubocop: - Layout/EmptyLines - Layout/EmptyLinesAroundAccessModifier - Layout/EmptyLinesAroundBlockBody - Layout/EmptyLinesAroundClassBody - Layout/EmptyLinesAroundMethodBody - Layout/EmptyLinesAroundModuleBody - Layout/ExtraSpacing
rubocop: - Layout/IndentationConsistency - Layout/IndentationWidth - Layout/MultilineMethodCallIndentation
rubocop: - Layout/SpaceAfterComma - Layout/SpaceAroundEqualsInParameterDefault - Layout/SpaceAroundOperators - Layout/SpaceInsideBlockBraces - Layout/SpaceInsideHashLiteralBraces
rubocop: Layout/TrailingBlankLines
rubocop: Lint/AmbiguousRegexpLiteral
rubocop: Lint/AssignmentInConditions
rubocop: Lint/DuplicateMethods
rubocop: Lint/IneffectiveAccessModifier
rubocop: Lint/UriEscapeUnescape
rubocop: Lint/UselessAssignment
rubocop: Performance/RedundantMerge
rubocop: Style/AndOr
rubocop: - Style/BracesAroundHashParameters - Style/EmptyLiteral - Style/EmptyMethod - Style/MethodDefParentheses
rubocop: Style/StringLiterals
rubocop: Style/UnneededInterpolation
rubocop: Style/RedundantSelf
rubocop: Style/RaiseArgs
rubocop: Style/Next
rubocop: Style/NegatedIf
rubocop: Style/MutableConstant
rubocop: Style/InverseMethods
rubocop: Style/IfUnlessModifier
rubocop: Style/GuardClause
rubocop: Style/ExpandPathArguments
rubocop: Style/ConditionalAssignment
rubocop: Style/ClassCheck
Rather than string interpolation or concatenation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these commits change behavior, they simply fill in specs for the existing behavior. A few of the specs are currently marked as pending due to known issues (e.g. #11 and #12).
The utility function for camel-casing strings was using ActiveSupport's
#camelizemethod, so I added that gem as a dependency to allow specs to run.