VS code: automatically watch ghcid.txt #313
Conversation
chrismwendt
force-pushed
the
vscode-auto-watch
branch
from
86e91a4
to
787551f
Compare
chrismwendt
force-pushed
the
vscode-auto-watch
branch
from
8bfc392
to
2e17851
Compare
|
@ndmitchell Does this look good to merge? |
There was a problem hiding this comment.
Sorry, been dragged away from open source work with family stuff for a few weeks. Looks awesome. Also looks like you're now the person who knows most about this code, as I barely remember much of it. Want to add your name in as author/maintainer for the package too?
| @@ -7,7 +7,7 @@ | |||
| "type": "extensionHost", | |||
| "request": "launch", | |||
| "runtimeExecutable": "${execPath}", | |||
| "args": ["--extensionDevelopmentPath=${workspaceRoot}" ], | |||
| "args": ["--extensionDevelopmentPath=${workspaceRoot}", "${workspaceRoot}/../../test/foo", "${workspaceRoot}/../../test/foo/Root.hs" ], | |||
There was a problem hiding this comment.
Yes, the ../../test/foo directory within this repo is very convenient for developing/debugging. I used it all the time when working on this PR. IMO it's a sensible default that can be changed pretty easily.
|
👍 Added myself as an author. |
|
Great. Do you have any additional changes incoming, or shall I push this to the extension store? (will probably be in the next 2 days) |
|
No additional changes incoming, thanks for merging 🙇♂️ |
This restores the ability to get error diagnostics from an existing ghcid process that writes
ghcid.txtto any subdirectory in the VS Code workspace.Here's a screenshot of files from 2 separate Haskell projects, each file's errors are coming from a different ghcid process:
I also stripped the line previews and indentation from hovers:
Before
After
Resolves #239 by restoring watch functionality that was removed in #118 and improving on it a bit.