Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show proposal status #43

Merged
merged 11 commits into from
Aug 21, 2023
Merged

Show proposal status #43

merged 11 commits into from
Aug 21, 2023

Conversation

amityadav0
Copy link
Contributor

@amityadav0 amityadav0 commented Aug 18, 2023 •
edited
Loading

  • Show proposal status
  • Should return enum: NOT_STARTED, ONGOING, COOLDOWN, ENDED
  • Add test

@amityadav0 amityadav0 requested a review from a team as a code owner August 18, 2023 13:36
sczembor
sczembor reviewed Aug 18, 2023
View reviewed changes
elections/src/proposal.rs Outdated Show resolved Hide resolved
sczembor
sczembor reviewed Aug 18, 2023
View reviewed changes
elections/src/view.rs Outdated Show resolved Hide resolved
sczembor
sczembor reviewed Aug 18, 2023
View reviewed changes
Copy link
Contributor

@sczembor sczembor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few suggestions. Also please provide a full description of the proposed changes

robert-zaremba
robert-zaremba reviewed Aug 18, 2023
View reviewed changes
elections/src/proposal.rs Outdated Show resolved Hide resolved
elections/src/view.rs Outdated Show resolved Hide resolved
elections/src/view.rs Outdated Show resolved Hide resolved
robert-zaremba
robert-zaremba approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving. Please make sure to apply suggestion (already set it in the code suggestion) to use Option

elections/src/proposal.rs Outdated Show resolved Hide resolved
elections/src/view.rs Outdated Show resolved Hide resolved
@amityadav0 amityadav0 merged commit abecf20 into master Aug 21, 2023
2 of 3 checks passed
@amityadav0 amityadav0 deleted the proposal-view branch August 21, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sczembor sczembor sczembor left review comments

@robert-zaremba robert-zaremba robert-zaremba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amityadav0 @robert-zaremba @sczembor