Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support regex patterns in module names #1104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kvalev
Copy link

@kvalev kvalev commented Jan 19, 2021

No description provided.

@nedbat
Copy link
Owner

nedbat commented Jan 22, 2021

Hi, thanks. Could you provide some explanation of what problem this is solving? I thought there was an issue written about this, but I can't find it now.

@kvalev
Copy link
Author

kvalev commented Jan 22, 2021

Hi, I had another PR, but decided to create a new one, as the other one was getting quite stale.

The PR will be helpful for us, as we are using one framework (airflow), which generates code in temporary modules on the fly. So in case we want to measure the code coverage of the generated modules (we do), we need a way to match the dynamic module names and this is where the regex support comes into play.

@ProsperousHeart
Copy link
Contributor

@kvalev - what was the original PR? opening a new one just because the old one is stale makes it difficult for maintainers.

Is this request still valid at all?

@kvalev
Copy link
Author

kvalev commented Mar 20, 2023

@ProsperousHeart Here is the original PR - #917 and yes, the request is still valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants