Test error handling in setup.py #1824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedbat
reviewed
Jul 28, 2024
| @@ -27,6 +29,12 @@ def setUp(self) -> None: | |||
| # Force the most restrictive interpretation. | |||
| self.set_environ('LC_ALL', 'C') | |||
|
|
|||
| def raise_error(self, error: type[Exception]) -> Callable[[Any], Any]: | |||
There was a problem hiding this comment.
This seems like something to use unittest.mock or pytest's monkeypatch for. But see below.
| # Do we handle all expected errors? | ||
| for ext_error in setup.ext_errors: | ||
| with pytest.raises(setup.BuildFailed): | ||
| setup.build_ext.build_extension = self.raise_error(ext_error) |
There was a problem hiding this comment.
These tests are mostly checking that we catch certain errors. I'd be more interested in tests that demonstrated actual failure scenarios and that we handled them well, but that seems harder to do. I'm not sure we need these tests.
There was a problem hiding this comment.
Agreed, closing. If I figure out a way to construct actual failure scenarios I'll propose another PR with realistic tests. Thanks for taking a look!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some tests for exception handling in setup.py.
It currently uses direct monkey-patching, please let me know if using
mock,patchor some other method would be better/cleaner.I'd be happy to add or remove some of the testing done, as well as reworking or otherwise polishing this PR.