support file path to base64 in parse #3487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For NEF base64, seems not with the same way. But maybe create another method like |
I see. This is base64(base64(.nefFile)) |
Hecate2
changed the title
|
Changed this PR to support only file path to base64 |
AnnaShaleva
reviewed
Sep 12, 2024
| { | ||
| if (!File.Exists(path)) return null; | ||
| return Convert.ToBase64String(File.ReadAllBytes(path)); | ||
| } |
There was a problem hiding this comment.
To be honest, I don't think we need this command for CLI because it's always possible to cat file.txt | base64.
There was a problem hiding this comment.
It's also possible but the command is a bit longer.
| [ParseFunction("File path to content base64")] | ||
| private string? FilePathToContentBase64(string path) | ||
| { | ||
| if (!File.Exists(path)) return null; |
There was a problem hiding this comment.
Make it allow only nef file extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An enhancement for #3482 (but also works alone). Hex string input had already been supported in the method
Base64Fixed, and is not considered.Type of change
How Has This Been Tested?
parse C:\Users\some_file.nef_or_anythingTypically it prints quite a few screens of hex, base64 and instructions, if the input is a .nef path. It works when the input path includes spaces. The user can wrap the input path with or without double quotation marks
", whether the path includes spaces or not.Checklist: