Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lua): refresh diagnostic for all loaded buffer #5261

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

fannheyward
Copy link
Member

No description provided.

@fannheyward
Copy link
Member Author

@statiolake can you give this a test and review? I'm not particularly familiar with the nvim Lua API, and there might be bugs or better implementation.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (abf20cd) to head (a67c577).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5261      +/-   ##
==========================================
+ Coverage   97.35%   97.37%   +0.01%     
==========================================
  Files         291      291              
  Lines       27040    27051      +11     
  Branches     5611     5612       +1     
==========================================
+ Hits        26324    26340      +16     
  Misses        497      497              
+ Partials      219      214       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fannheyward fannheyward force-pushed the fix/lua-diagnostic-all-buffers branch from 82b6b11 to c11dff9 Compare February 19, 2025 11:13
@fannheyward fannheyward force-pushed the fix/lua-diagnostic-all-buffers branch 2 times, most recently from d011f0e to d7cf842 Compare February 20, 2025 02:30
@fannheyward fannheyward requested a review from chemzqm February 20, 2025 09:56
Copy link
Member

@chemzqm chemzqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vim.tbl_count(items) > 0

@statiolake
Copy link
Contributor

Thank you for improvement! I tried this branch today and it works pretty well.

@fannheyward fannheyward force-pushed the fix/lua-diagnostic-all-buffers branch from d7cf842 to a67c577 Compare February 21, 2025 00:57
@fannheyward fannheyward merged commit 12d2587 into master Feb 21, 2025
3 of 4 checks passed
@fannheyward fannheyward deleted the fix/lua-diagnostic-all-buffers branch February 21, 2025 01:12
chemzqm added a commit that referenced this pull request Feb 21, 2025
1e177c4 feat(format): support b:coc_disable_autoformat
e7abca2 fix(autocmds): use unique group for each autocmd
7f81235 feat(client): add coc#client#get_log
12d2587 fix(lua): refresh diagnostic for all loaded buffer (#5261)
59a853a fix(locations): consider unicode on jump
80c9c22 feat(extensions): use extensions section for configuration
d11a0ad feat(completion): use textEditText when default range exists
a7e1ceb chore(extension): fix typo
61e65da chore(doc): remove doc for vim & nvim which not supported
65574c5 fix(diagnostic): correct display configurations (#5262)
811f395 docs: use BufRead in b:coc_enabled example (#5259)
abf20cd chore(deps-dev): bump esbuild from 0.24.0 to 0.25.0 (#5256)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants