Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Use NodeType -> references configuration instead of properties of type: reference/s #197

Open
wants to merge 1 commit into
base: 9.0
Choose a base branch
from
Open

TASK: Use NodeType -> references configuration instead of properties of type: reference/s #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions NodeTypes/Content/BlogPostingList/BlogPostingList.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@
label: i18n
icon: 'newspaper'
position: 50
properties:
references:
blogs:
type: references
ui:
label: i18n
showInCreationDialog: true
Expand All @@ -33,6 +32,7 @@
group: 'blog'
editorOptions:
nodeTypes: ['Neos.Demo:Document.Blog']
properties:
limit:
type: integer
defaultValue: 5
Expand Down
19 changes: 10 additions & 9 deletions NodeTypes/Content/ContactForm/ContactForm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@
label: i18n
icon: comment
tab: default
references:
redirect:
constraints:
maxItems: 1
ui:
label: i18n
inspector:
group: redirect
editorOptions:
nodeTyps: [ 'Neos.Neos:Document' ]
Comment on lines +35 to +36
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this here should also be moved to the constraints as the cr actually understands that but i forgot if the neos ui can handle it already :)

properties:
subject:
type: string
Expand Down Expand Up @@ -60,15 +70,6 @@
label: i18n
inspector:
group: email
redirect:
type: reference
defaultValue: null
ui:
label: i18n
inspector:
group: redirect
editorOptions:
nodeTyps: ['Neos.Neos:Document']
message:
type: string
defaultValue: ''
Expand Down
3 changes: 1 addition & 2 deletions NodeTypes/Document/Homepage/Homepage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,8 @@
'footer':
position: 'end'
type: 'Neos.Demo:Collection.Content.Footer'
properties:
references:
metaNavigationItems:
type: references
ui:
label: i18n
inspector:
Expand Down
2 changes: 1 addition & 1 deletion NodeTypes/Override/ContentReferences.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
superTypes:
'Neos.Demo:Constraint.Content.Main': true
'Neos.Demo:Constraint.Content.Column': true
properties:
references:
references:
ui:
showInCreationDialog: true
2 changes: 1 addition & 1 deletion Resources/Private/Translations/de/NodeTypes/Content/BlogPostingList.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<source>Blog</source>
<target state="translated">Blog</target>
</trans-unit>
<trans-unit id="properties.blogs" xml:space="preserve">
<trans-unit id="references.blogs" xml:space="preserve">
<source>Blogs</source>
</trans-unit>
<trans-unit id="properties.limit" xml:space="preserve">
Expand Down
2 changes: 1 addition & 1 deletion Resources/Private/Translations/de/NodeTypes/Content/ContactForm.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<source>Message after submit</source>
<target state="translated">Nachricht nach dem Senden</target>
</trans-unit>
<trans-unit id="properties.redirect" xml:space="preserve">
<trans-unit id="references.redirect" xml:space="preserve">
<source>Redirect after submit</source>
<target state="translated">Weiterleitung nach dem Senden</target>
</trans-unit>
Expand Down
2 changes: 1 addition & 1 deletion Resources/Private/Translations/de/NodeTypes/Document/Homepage.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<trans-unit id="tabs.site" xml:space="preserve">
<source>Site configuration</source>
</trans-unit>
<trans-unit id="properties.metaNavigationItems" xml:space="preserve">
<trans-unit id="references.metaNavigationItems" xml:space="preserve">
<source>Meta navigation items</source>
</trans-unit>
</body>
Expand Down
2 changes: 1 addition & 1 deletion Resources/Private/Translations/en/NodeTypes/Content/BlogPostingList.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<trans-unit id="groups.blog" xml:space="preserve">
<source>Blog</source>
</trans-unit>
<trans-unit id="properties.blogs" xml:space="preserve">
<trans-unit id="references.blogs" xml:space="preserve">
<source>Blogs</source>
</trans-unit>
<trans-unit id="properties.limit" xml:space="preserve">
Expand Down
2 changes: 1 addition & 1 deletion Resources/Private/Translations/en/NodeTypes/Content/ContactForm.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<trans-unit id="properties.message" xml:space="preserve">
<source>Message after submit</source>
</trans-unit>
<trans-unit id="properties.redirect" xml:space="preserve">
<trans-unit id="references.redirect" xml:space="preserve">
<source>Redirect after submit</source>
</trans-unit>
<trans-unit id="properties.recipientName" xml:space="preserve">
Expand Down
2 changes: 1 addition & 1 deletion Resources/Private/Translations/en/NodeTypes/Document/Homepage.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<trans-unit id="tabs.site" xml:space="preserve">
<source>Site configuration</source>
</trans-unit>
<trans-unit id="properties.metaNavigationItems" xml:space="preserve">
<trans-unit id="references.metaNavigationItems" xml:space="preserve">
<source>Meta navigation items</source>
</trans-unit>
</body>
Expand Down