FEATURE: Make MultiSelectBox drag&drop sorting feature optional #3827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er than the image itself
Co-authored-by: Wilhelm Behncke <[email protected]>
Currently translated at 100.0% (121 of 121 strings) Translation: Neos/Neos.Ui - Main - 8.3 Translate-URL: https://hosted.weblate.org/projects/neos/neos-ui-main-8-3/nl/
Currently translated at 100.0% (121 of 121 strings) Translation: Neos/Neos.Ui - Main - 8.3 Translate-URL: https://hosted.weblate.org/projects/neos/neos-ui-main-8-3/es/
…ect site Fixes neos#3795 Neos uses shared sessions when working with multiple sites on different domains. This fix ensures that we do not try to open a lastVisitedNode within a site the node does not belong to.
…ectly Initially the user could set a placeholder, but inside the `LinkInput.js` it wouldn't be used and an unnecessary static placeholder would be used instead Fixes neos#3797
…r on empty `placeholder:` setting If someone leaves the `placeholder:` setting empty, the default placeholder, instead of a completely empty `LinkEditor`-input will be shown. Fixes neos#3797
Currently translated at 100.0% (121 of 121 strings) Translation: Neos/Neos.Ui - Main - 8.3 Translate-URL: https://hosted.weblate.org/projects/neos/neos-ui-main-8-3/de/
BUGFIX: `LinkEditor` placeholder now uses the custom placeholder correctly
Updated by "Remove blank strings" hook in Weblate. Co-authored-by: Hosted Weblate <[email protected]> Translate-URL: https://hosted.weblate.org/projects/neos/neos-ui-main-8-3/ Translation: Neos/Neos.Ui - Main - 8.3
Co-authored-by: Marc Henry Schultz <[email protected]>
BUGFIX: findNodeToEdit() checks if the node belongs to the correct site
… create schema for invalid entries
…es like filtering
BUGFIX: Let document tree searchbox scale with sidebar width
The bool filter here is broken. we must keep the real index see daggableValues[dragIndex];: neos#3520 (comment)
…gmentation BUGFIX: Prevent augmenter from applying data of multiple nodes into the same element
… positioning When the inspector tab panel is scrolled just enough, so that there\'s enough space, SelectBox contents jump below the SelectBox. Would fail otherwise because "document" would be before "tests"
✖ Select Boxes - SelectBox opens above in creation dialog if there's not enough space below.
1) Unable to resize the window because the specified size exceeds the screen size. On macOS, a window cannot be larger than the screen.
Browser: Chrome 129.0.0.0 / Ventura 13
21 | .gt(await ReactSelector('NodeCreationDialog SelectBox').getBoundingClientRectProperty('top'));
22 |});
23 |
24 |test('SelectBox opens above in creation dialog if there\'s not enough space below.', async t => {
25 | await t
> 26 | .resizeWindow(1200, 768)
> WRN Suite errored. error="job start failed (404): Misconfigured -- Resolution you specified is not available for this OS/browser/version/device combo: OS: 'Mac 13', Browser: 'googlechrome', Version: '129.0.6668.59', Device: 'unspecified', Screen Resolution: '1920x1080'; available resolutions: '1024x768', '1152x864', '1280x960', '1376x1032', '1440x900', '1600x1200', '1920x1440', '2048x1536'"
The retrys just fail: Sauce TestCafe Runner 3.9.0 2Running TestCafe 3.6.2 8Error: Cannot find module '/Volumes/Sauce/node/20.14.0/node-v20.14.0-darwin-x64/bin/node_modules/npm/bin/npm-cli.js' 25 26Error: Cannot find module '/Volumes/Sauce/node/20.14.0/node-v20.14.0-darwin-x64/bin/node_modules/npm/bin/npm-cli.js' 56ERROR No tests match your filter. 57See https://testcafe.io/documentation/402638/reference/configuration-file#filter. 58 59Type "testcafe -h" for help. 60JUnit file generation skipped: no test suites detected.
TASK: Backport the end to end tests from 8.4
FIX: Sizing of icons in alerts
|
Ping @laurahaenel |
|
Mh I cant rerun the circle ci tests (no permissions). I tried to run them locally but the setup is not correct on my machine. I will have a deeper look into it to get the same (failing) test results. Or should I just rebase? |
* TASK: Add docs for contribution getting started * TASK: Adds code-style --------- Co-authored-by: Markus Günther <[email protected]>
Whitespaces like a tab can lead to a 404 error if a URL has been pasted to a LinkEditor or LinkInput. As datasources, assets, URLs and slugs should not start with a whitespace, we can remove them. Fixes: neos#3859
Ensure that searchTerm is a string before trimming the value.
…eos#3864) * BUGFIX: Restore old Placeholder behavior to keep shown when focused In Neos 7.3.17 and before the placeholder in ckeditor would not disappear when focused. And only when typing. By switching to the native placeholder feature of ckeditor in neos#3558 we introduced a regression as that implementation would hide the placeholder while just clicking into. This is especially noticeable for centered texts as the cursor needs one millisecond to adjust and its glitchy. This will eventually be fixed in Ckeditor 24 something. As a hotfix for our version 16 i introduce the patch of ckeditor/ckeditor5#8474 (without the css absolute change as that would make centered text uneditable). The mentioned fix was not merged directly into ckeditor but made way more complicated: ckeditor/ckeditor5#8867 We dont need the more complicated fix as we dont use the mentioned features of the placeholder in a image description and such. * TASK: Move cursor before the placeholer * TASK: Hide break in placeholder context To move the cursor to the first position, the placeholder text is moved backwards. Therefore, a change with a break is disadvantageous. --------- Co-authored-by: Markus Günther <[email protected]>
…tiSelectBox-drag&drop-sorting-feature-optional' into feature/3715-Make-MultiSelectBox-drag&drop-sorting-feature-optional
|
I think I will make a new branch, this one is outdated and neither rebase nor merge is feasible 😅 Cherry-picking it is This is the new MR #3874 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #3715 .
What I did
How I did it
How to verify it
allowDragging={true}(Packages/Application/Neos.Neos.Ui/packages/neos-ui-editors/src/Editors/AssetEditor/index.js)With
allowDragging={false}:Default:
