fix undefined behavior in count_mmac_params #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiled
-fsanitize=undefined
nasm produced this error message:The problem is reproducible on tests
avx512f
,avx512cd
,avx512pf
andavx512er
in the test suite.The problematic line was:
When
t
isNULL
this line doesn't cause memory access, but it is still an undefined behavior according to C standard.I believe that the underlying problem is that this loop doesn't have a sound invariant about
maybe_comma
:*maybe_comma == t->next
*maybe_comma == t
I don't know what the intended loop invariant is and I decided to just mechanically fix the deferencing of
NULL
pointer, completely preserving the existing behavior.