fix memory leak in -E mode #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorokin
force-pushed
the
fix-memory-leak-in-E-mode
branch
from
cc169e6
to
4e3099c
Compare
When running with -fsanitize=leak enabled nasm prints this error:
Direct leak of 114 byte(s) in 10 object(s) allocated from:
#0 0x7f3031ef0867 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
netwide-assembler#1 0x564dc07a2f6c in nasm_malloc nasmlib/alloc.c:55
netwide-assembler#2 0x564dc07f606a in detoken asm/preproc.c:2029
netwide-assembler#3 0x564dc0828a62 in pp_getline asm/preproc.c:7835
netwide-assembler#4 0x564dc0797f3e in main asm/nasm.c:654
netwide-assembler#5 0x7f3031608d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
netwide-assembler#6 0x7f3031608e3f in __libc_start_main_impl ../csu/libc-start.c:392
netwide-assembler#7 0x564dc0799c24 in _start (/home/ivan/d/nasm/nasm+0x2e5c24)
This is reproducible on tests that do preprocessing for example
weirdpaste.asm test.
The problem is caused by the fact that the line returned by pp_getline
isn't freed in main function.
Signed-off-by: Ivan Sorokin <[email protected]>
sorokin
force-pushed
the
fix-memory-leak-in-E-mode
branch
from
4e3099c
to
31816e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with
-fsanitize=leakenabled nasm prints these errors:This is reproducible on tests that do preprocessing for example
weirdpastetest.The problem is caused by the fact that the line returned by
pp_getlineisn't freed inmainfunction.