Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python versions to adhere to SPEC 0 #442

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Update Python versions to adhere to SPEC 0 #442

merged 2 commits into from
Feb 26, 2025

Conversation

adamltyson
Copy link
Member

Description

Updates the Python versions to adhere to SPEC 0

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
qt-niu is only available for SPEC 0 Python versions (3.11-3.13). This will break the conda-forge process when it's added as a dependency. Now seemed like a good idea to update the supported versions here, as (as far as I know) all the dependencies support 3.13.

In places where the version wasn't the oldest or newest, I've tried to update it in the same way, e.g. keeping the middle version.

@adamltyson adamltyson requested a review from a team February 26, 2025 07:54
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (115fd46) to head (e096a20).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          23       23           
  Lines        1312     1312           
=======================================
  Hits         1310     1310           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niksirbi
Copy link
Member

niksirbi commented Feb 26, 2025

Thank Adam, this closes #332.

I was meaning to do that for a while now, but last time I'd checked we were held back by numba. That doesn't seem to be the case any more.

@niksirbi
Copy link
Member

I tried refreshing the CI, but it keeps getting stuck on "Waiting for status to be reported".
Any suggestions? Should I just override and merge it or do we have reasons to worry there may be an actual problem?

@lochhh
Copy link
Collaborator

lochhh commented Feb 26, 2025

I tried refreshing the CI, but it keeps getting stuck on "Waiting for status to be reported". Any suggestions? Should I just override and merge it or do we have reasons to worry there may be an actual problem?

How about recreating the PR?

@adamltyson
Copy link
Member Author

I would just merge as-is. It will get tested with every new PR, and if any issues crop up they can be fixed.

@niksirbi niksirbi enabled auto-merge February 26, 2025 18:04
@niksirbi niksirbi disabled auto-merge February 26, 2025 18:05
@niksirbi niksirbi merged commit bdb514f into main Feb 26, 2025
28 checks passed
@niksirbi niksirbi deleted the python-versions branch February 26, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants