Merge pull request #465 from nevalang/lint #789
emil14Annotations
10 errors and 12 warnings
|
lint:
internal/compiler/desugarer/struct_selectors.go#L14
error strings should not be capitalized or end with punctuation or a newline (golint)
|
|
lint:
internal/interpreter/interpreter.go#L12
struct of size 176 bytes could be of size 168 bytes (maligned)
|
|
lint:
internal/compiler/irgen/irgen.go#L28
`constValue` is unused (structcheck)
|
|
lint:
internal/compiler/irgen/net.go#L66
(Generator).processSenderSide - result 1 (error) is always nil (unparam)
|
|
lint:
internal/compiler/desugarer/const_sender.go#L36
(Desugarer).handleLiteralSender - result 1 (*github.com/nevalang/neva/internal/compiler.Error) is always nil (unparam)
|
|
lint:
internal/compiler/desugarer/then_connections.go#L39
(Desugarer).handleThenConns - result 1 (*github.com/nevalang/neva/internal/compiler.Error) is always nil (unparam)
|
|
lint:
internal/compiler/parser/listener_helpers.go#L204
parseEntityRef - result 1 (error) is always nil (unparam)
|
|
lint:
internal/compiler/desugarer/struct_selectors.go#L120
func `Desugarer.getStructFieldType` is unused (unused)
|
|
lint:
internal/compiler/desugarer/struct_selectors.go#L160
var `structSelectorEntityRef` is unused (unused)
|
|
lint:
internal/interpreter/interpreter.go#L20
Function `CompileToIR` should pass the context parameter (contextcheck)
|
|
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
lint:
internal/compiler/irgen/net.go#L62
unused-parameter: parameter 'scope' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
internal/compiler/irgen/net.go#L125
unused-parameter: parameter 'outports' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
internal/compiler/backend/golang/backend.go#L50
if-return: redundant if ...; err != nil check, just return error instead. (revive)
|
|
lint:
internal/compiler/backend/golang/native/backend.go#L24
if-return: redundant if ...; err != nil check, just return error instead. (revive)
|
|
lint:
internal/pkgmanager/manager.go#L89
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
internal/pkgmanager/mod.go#L32
if-return: redundant if ...; err != nil check, just return error instead. (revive)
|
|
lint:
internal/pkgmanager/mod.go#L13
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
internal/compiler/parser/err_handler.go#L18
unused-parameter: parameter 'offendingSymbol' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
internal/compiler/parser/listener.go#L10
unused-parameter: parameter 'actx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
internal/compiler/parser/err_handler.go#L21
unused-parameter: parameter 'e' seems to be unused, consider removing or renaming it as _ (revive)
|