-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XKit Preferences] Dark Mode Update 2 #2024
base: master
Are you sure you want to change the base?
[XKit Preferences] Dark Mode Update 2 #2024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few quick notes—i don't have a lot of context on the current state of this code, i might not be the best person to review the rest of it
Extensions/xkit_preferences.css
Outdated
--xkit-11-overlay: rgba(0,0,0,.11); | ||
--xkit-22-overlay: rgba(0,0,0,.22); | ||
--xkit-33-overlay: rgba(0,0,0,.33); | ||
--xkit-44-overlay: rgba(0,0,0,.44); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're changing a lot of -shadow
variable usage to -overlay
in this PR. going forward, when would someone use -shadow
vs using -overlay
? is -shadow
superfluous now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced all --shadow
variables that do not describe a box-shadow or text-shadow to be an --overlay
instead. I did this for two reasons:
- It's more descriptive this way.
--overlay
denotes something that will colour the entire element (ie hovering over a tab), whereas--shadow
is now only used for shadows (ie text-shadows and box-shadows). - Dark Mode inverts the shadow colours (ie
--shadow
goes from black to white, and--white-shadow
goes from white to black). But not all shadows should be inverted, such as--shadow
(which goes from black to white) because it creates white box-shadows which look really odd because they're not as intuitive as black shadows). But some overlays are still useful, so I split them up into--shadow
and--overlay
so that I can invert--overlay
while turning off--shadow
.
If you don't do this (ie no --overlay
variables and invert every shadow), then you get this result:
Weird white box-shadows.
Redid #1848 with the current master.
Original Description:
Put in some logic (using checkboxes) for the XKit Control Panel to:
Updated some class styles with items that weren't previously defined and so defaulted to black (not very clear against a dark background), and also added more variables because white box-shadows are not really a great design choice in dark themes.
As a bonus, changed the default and kernel extension icons to SVGs for crispness and space!