Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): bump ckeditor family (main) (major) #8642

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(deps): bump ckeditor family (main) (major) #8642

wants to merge 2 commits into from
+23,837 −9,592

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 21, 2023 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@ckeditor/ckeditor5-alignment (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-basic-styles (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-block-quote (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-core (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-dev-utils (source) 37.0.1 -> 43.0.1 age adoption passing confidence
@ckeditor/ckeditor5-editor-balloon (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-editor-decoupled (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-essentials (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-font (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-heading (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-image (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-link (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-list (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-mention (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-paragraph (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-remove-format (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-theme-lark (source) 37.1.0 -> 44.2.0 age adoption passing confidence
@ckeditor/ckeditor5-upload (source) 37.1.0 -> 44.2.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

ckeditor/ckeditor5 (@​ckeditor/ckeditor5-alignment)

v44.2.0

Compare Source

We are happy to announce the release of CKEditor 5 v44.2.0.

Release Highlights
🖥️ Enhanced Source Code Editing (⭐)

Introducing new premium feature: Enhanced Source Code Editing. It displays the source code in a dialog and is compatible with all editor types. It offers syntax highlighting, code completion, code folding, and other advanced functionalities. Additionally, it supports both HTML and Markdown formats.

📤 Uploadcare and image optimizer (⭐)

We have integrated the Uploadcare image manager service, enabling you to upload and edit images to their cloud environment. You can upload files from various sources, including local devices, social media, or online drives ensuring rapid uploads. The integration takes care of efficient media delivery with responsive images mechanism, making sure your users will save bandwidth and have faster website loading. You can also optimize images with the built-in image editor which offers a range of features, such as cropping, rotating, flipping, photo filters and more. All this directly from the editor, try it out!

🖼️ Image Merge Fields (⭐)

Image merge fields are a new type of merge fields, dedicated for image placeholders. They maintain all standard image interactions, like styling, resizing or captions (in which you can use merge fields too!) At the same time, they keep all merge fields functionalities, like data previews or document export integration. In the document data, image merge fields are represented like other images, however their src attribute is set to a respective merge field, for example, src="{{CompanyLogo}}", making them easy to post-process!

📝 Track Changes Preview (⭐)

We have added the preview mode that displays a document with all suggestions accepted. Accessible from the track changes dropdown, this modal preview helps check the final content without extensive markers.

😀 Emoji support

They are here! 🎉 🥳 🎊 Insert emojis effortlessly in the editor by typing : or through a user-friendly emoji picker. This feature enhances the richness of your content by allowing quick access to a wide range of emojis.

⚡ Performance improvements: Part 4

Here comes the final batch of the planned performance improvements in the editor loading speed area, that we worked on through a couple of past releases.

  • A new caching mechanism in Mapper now handles model-to-view mappings, substantially improving performance for loading and saving data.
  • Images with specified height and width automatically use [loading="lazy"] in the editing area, optimizing the loading time (read more on MDN). This attribute is only applied during editing to enhance the loading efficiency of images, and it does not reflect in the final data output.

We are greatly satisfied with the improved editor loading times. At the same time, we acknowledge some other problematic areas, and we will keep delivering more performance-related improvements in the future.

MINOR BREAKING CHANGES ℹ️
  • engine: Mapper#registerViewToModelLength() is now deprecated and will be removed in one of the upcoming releases. This method is useful only in obscure and complex converters, where model element, or a group of model elements, are represented very differently in the view. We believe that every feature using a custom view-to-model length callback can be rewritten in a way that this mechanism is no longer necessary. Note: if this method is used, the caching mechanism for Mapper will be turned off which may degrade performance when handling big documents. Note: this method is used by the deprecated legacy lists feature. As a result, you will not experience the performance improvements if you are still using the deprecated legacy lists feature.
  • image: Starting this release, images that have [height] and [width] attributes set will automatically receive the [loading="lazy"] attribute in the editing area. This happens only for the content loaded into the editor, the data output produced by the editor remains the same. The reason for this change is to improve user experience in documents that may contain hundreds of images.
  • list: The lower-alpha and upper-alpha list styles are now upcasted to lower-latin and upper-latin styles.
  • merge-fields: The MergeFieldsEditing#getLabel() method will now return null instead of the merge field id if the merge field definition was not found or it did not contain the label property.
  • basic-styles: Elements which contains the [style] attribute with word-wrap: break-word will not be converted to <code>. See #​17789.
Features
  • ai: Comment threads will now be preserved when AI Assistant processes selected content with comments. This can be disabled through the ai.aiAssistant.preserveComments flag. Note, that the actual result depends on the response provided by the AI model (AI model has to keep the comments markup in the response). Additionally, the copy-paste comments functionality must be enabled (configured by comments.copyMarkers).
  • ai: The ai.aiAssistant.removeCommands configuration now allows removing entire command groups.
  • ckbox: It is now allowed to specify which files chosen from CKBox are downloadable. Closes #​15928. (commit)
  • clipboard: Added the ability to detect paste events originating from the editor. Closes #​15935. (commit)
  • clipboard: Passed information to the downcast converter when clipboard pipeline is used to allow for customization. Closes #​17745. (commit)
  • clipboard: The viewToPlainText() helper will now parse the view RawElement instances. Closes #​17746. (commit)
  • emoji: Created the Emoji feature. Closes #​17361. (commit)
  • image: Added a possibility to break the current block by InsertImageCommand with the breakBlock flag. Closes #​17742. (commit)
  • list: Allowed to specify which list style types are shown in list type selector dropdown. Closes #​17176. (commit)
  • list: Added support for the lower-alpha and upper-alpha list type highlighting in the list style properties buttons. Closes #​17424. (commit)
  • mention: Allowed the mention marker to be longer than 1 character. Closes #​17744. (commit)
  • merge-fields: Introduced the image merge fields.
  • merge-fields: Added the [data-merge-field-name] attribute in the editing pipeline.
  • merge-fields: Use the actual merge field value when they are copied from the editor in preview mode other than $labels.
  • source-editing-enhanced: Introduced the Enhanced Source Code Editing feature.
  • table: Improve aria attributes in the table and cell align toolbars. Closes #​17722. (commit)
  • track-changes: Introduced the final document preview for track changes. It allows to display the document with all suggestions accepted in the modal.
  • ui: The .ck-with-instant-tooltip class may now be used to display the tooltip without the delay. Closes #​17743. (commit)
  • upload: Added support for passing a callback to the SimpleUploadConfig#headers property. Closes #​15693. (commit)
  • uploadcare: Introduced the Uploadcare integration.
  • utils: Added a collectStylesheets() helper function to retrieve style sheets from the provided URLs. (commit)
Bug fixes
  • ai: The content generated by the AI Assistant will now be correctly inserted into tables when both "Replace" and "Insert below" actions are used.
  • basic-styles: The Code feature should not convert element with the word-wrap: break-word style into the <code> tag. Closes #​17789. (commit)
  • cloud-services: No longer keep refreshing token if the cloudServices.tokenUrl method failed in the initialization of the plugin. Closes #​17531. (commit)
  • comments: Unlinked comment threads created before the editor initialization are now correctly handled and displayed in the comments archive. This error was experienced in asynchronous integrations which are using the Context mechanism.
  • comments: Do not allow editing content source via the source mode in the comments-only mode.
  • comments: Introduced the name field tooltip in comments UI.
  • editor-classic: Export ClassicEditorUIView from package. (commit)
  • editor-inline: No longer crash while destroying the editor when the editable was manually detached before destroying. Closes #​16561. (commit)
  • editor-multi-root: No longer crash while destroying the editor when the editable was manually detached before destroying. Closes #​16561. (commit)
  • image: The insert image via URL dialog can now be submitted by pressing the Enter key. Closes #​16902. (commit)
  • link: Trailing punctuation is no longer included in an autolinked URL. Closes #​14497. (commit)
  • list: The list style buttons should show proper list type after clicking list for the first time. (commit)
  • list-multi-level: Multi-level lists should work when typing in Japanese.
  • merge-fields: Do not automatically convert the merge-fields-like text containing disallowed characters.
  • merge-fields: Properly handle block merge fields mixed with text during data upcast and pasting.
  • revision-history: The Revision history feature sidebar header height now matches the height of the editor toolbar.
  • revision-history: The Revision history feature loading overlay now overlaps images correctly.
  • table: Prevent a table corruption when setting editor data with <th> cells following colspan rows. Closes #​17556, #​17404. (commit)
  • track-changes: Introduced the name field tooltip in suggestions UI.
  • typing: Fixed not working two-step caret movement on iOS devices. Closes #​17171. (commit)
  • ui: Tooltip will no longer show after quickly hovering and moving the mouse away before the tooltip shows. Closes #​16949. (commit)
  • ui: Destroying another editor instance while a modal is open will no longer unlock page scroll. Closes #​17585. (commit)
  • utils: Extended getEnvKeystrokeText() with option to use it in the context of specified environment which allows to generate keystrokes text for different OS than the host one. (commit)
  • Treat types as production dependencies. Fixes #​17213. (commit)
  • Unify TypeScript declaration files. Fixes #​17575 and #​17533. (commit)
Other changes
  • ai: Exported the AIAssistantUI class and the AIAssistantConfig, CommandDefinition and GroupDefinition types.
  • clipboard: Exported the ViewDocumentPasteEvent type from the @ckeditor/ckeditor5-clipboard package. (commit)
  • comments: Exported the AddCommentThreadEventData type.
  • comments: Activating an annotation now scrolls to the target if it is out of view.
  • comments: Fixed the wrong filter() callback signature in AnnotationsUIs#activate().
  • engine: Introduced dynamic caching in Mapper to improve view-to-model mapping performance, and as a result improve editor data load and data save performance. Closes #​17623. (commit)
  • engine: A new parameter data was added for the change:children event fired by ViewElement and ViewDocumentFragment when their children change. The data parameter is an object with the index property, which says at which index the change happened. Related to #​17623. (commit)
  • engine: Mapper#registerViewToModelLength() is now deprecated and will be removed in one of upcoming releases. Note: if this method is used, the caching mechanism for Mapper will be turned off which may degrade performance when handling big documents. Note: this method is used by the deprecated legacy lists feature. See #​17623. (commit)
  • engine: Export SchemaCompiledItemDefinition type. Closes #​17783. (commit)
  • engine: Improve performance of the placeholders. (commit)
  • engine: Do not store non-document operation with batches. This improves memory efficiency for huge documents. Closes #​17678. (commit)
  • engine: Improve performance of Selection#getSelectedBlocks when selection contains block elements with many blocks inside (such as table). Closes #​17629. (commit)
  • font: Export ColorSelectorDropdownView type. Closes #​17783. (commit)
  • image: The [loading="lazy"] attribute will be automatically added in editing view to images with the height and width attributes set to improve loading performance. (commit)
  • list: Skip already visited list elements during reconversion and post fixing for better performance. Fixes #​17625. (commit)
  • merge-fields: The MergeFieldsEditing#refreshMergeFields() method is now public and available for external use.
  • merge-fields: Remove the default values preview mode if there is none or the merge fields has a default value configured.
  • merge-fields: Display ellipsis if the merge field name does not fit the dropdown.
  • pagination: Do not wait for images with [width] and [height] attributes.
  • pagination: Do not wait for loading images that have [width] and [height] attributes set when calculating pages.
  • real-time-collaboration: Export the Sessions class.
  • real-time-collaboration: Changed how errors related to real-time collaboration are handled. Previously, the original error was always logged on the console, and a realtimecollaborationclient- error was thrown without information related to the original error. Now, the original error is not logged anymore. Instead, the realtimecollaborationclient- error includes the data.originalError property with the original error message. This way it is possible to save error details through a custom error logging mechanism. Note, that without any custom mechanism, the realtimecollaborationclient- error will still be unhandled and logged to the console.
  • real-time-collaboration: The editor now switches to read-only mode if the real-time collaboration client crashes, ensuring that the user cannot further edit the document and no data is accidentally lost.
  • ui: Added Enhanced Source Code Editing as a default menu bar item, making it visible in the menu bar when the plugin is present in the editor. (commit)
  • ui: Extended the dialog API to support custom keystroke handler options, allowing to override priorities of the keystroke callback and filter keystrokes based on arbitrary criteria. (commit)
  • ui: The ImageInsertUI#registerIntegration method now supports handling an array of views for a specific integration type. This allows, for example, registering an assetManager integration with multiple sources like Facebook and Instagram, where each source has its own dedicated button. (commit)
  • ui: Exported the DocumentColorCollection class. Closes #​17783. (commit)
  • utils: Extended key codes with the End and Home keys, enabling the use and display of shortcuts containing these keys in the UI. (commit)
  • utils: Exported the add() function. Closes #​17783. (commit)
Released packages

Check out the Versioning policy guide for more information.

Released packages (summary)

New packages:

Minor releases (contain minor breaking changes):

Releases containing new features:

Other releases:

Configuration

📅 Schedule: Branch creation - "before 5am on wednesday" in timezone Europe/Vienna, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested review from ChristophWurst and GretaD July 21, 2023 08:12
@ChristophWurst ChristophWurst requested review from kesselb and removed request for ChristophWurst July 21, 2023 08:12
@ChristophWurst
Copy link
Member

@kesselb this one is for you :)

@ChristophWurst
Copy link
Member

ckeditor/ckeditor5#14082

^ @jancborchardt @marcoambrosini @nimishavijay ckeditor will show a ckeditor logo with v38 and later. Would that be a problem for us design-wise?

@nimishavijay
Copy link
Member

Where is this ckeditor used? :) And do we have control over how the logo is shown?

@ChristophWurst
Copy link
Member

ChristophWurst commented Jul 21, 2023 •
edited
Loading

CKEditor is the editor we use for the body of new emails. I don't think we have direct control over where/how the logo shows but we might be able to tweak that with css. Yet that's something we have to check with the license of the editor.

@kesselb
Copy link
Contributor

kesselb commented Jul 21, 2023

And do we have control over how the logo is shown?

They provide a couple of customization options: https://ckeditor.com/docs/ckeditor5/latest/support/licensing/managing-ckeditor-logo.html#how-to-configure-the-layout-of-the-powered-by-ckeditor-logo

@kesselb
Copy link
Contributor

kesselb commented Jul 21, 2023

Signature editor:

Screenshot from 2023-07-21 12-11-03

Composer view:

Screenshot from 2023-07-21 12-12-33

@kesselb
Copy link
Contributor

kesselb commented Jul 21, 2023

As idea:

Hiding the label and changing position is possible.

ui: {
	poweredBy: {
		position: 'inside',
		side: 'right',
		label: null,
		verticalOffset: 2,
		horizontalOffset: 2
	}
}

image

image

@nimishavijay
Copy link
Member

Screenshots by @kesselb look good to me. If possible we could link the image to their website/repo. @jancborchardt is this ok with you?

@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 6d235ba to 3bb986f Compare August 2, 2023 10:51
@renovate renovate bot changed the title fix(deps): bump ckeditor family from 37.1.0 to v38 (main) (major) fix(deps): bump ckeditor family from 37.1.0 to v39 (main) (major) Aug 2, 2023
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 3bb986f to 61fe5ff Compare August 10, 2023 07:46
@jancborchardt
Copy link
Member

jancborchardt commented Aug 10, 2023 •
edited
Loading

Oh wow, that's sort of invasive and nerdy.

  • Is CKEditor not really open source, as in we can't hide the logo? (We can happily have a note of it in the bottom left settings.)
  • Do we have to link the logo? Bottom right is the best placement but I am worried about misclicks when sending.

@kesselb
Copy link
Contributor

kesselb commented Aug 10, 2023 •
edited
Loading

Is CKEditor not really open source, as in we can't hide the logo? (We can happily have a note of it in the bottom left settings.)

Technically, we can hide the logo.

I can't judge whether that's okay or not. The topic is also discussed at ckeditor/ckeditor5#14082 (comment) and ckeditor/ckeditor5#14314.

Do we have to link the logo? Bottom right is the best placement but I am worried about misclicks when sending.

They don't provide an option to not generate a link.

image

I moved the send button to the left. Not much better.

Screencast.from.2023-08-10.22-35-07.webm

That's super annoying. The logo is visible if you focus on the editor.
I am uncertain if that was already the case for 38 or is new in 39.

@marcoambrosini
Copy link
Member

I also think that if it's open source we should hide the logo from the composer and add attribution in the app settings. Once those settings are moved to a settings dialog this could even be a small paragraph.

@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 61fe5ff to 305ca2e Compare September 6, 2023 10:35
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 305ca2e to c064b22 Compare October 4, 2023 13:15
@renovate renovate bot changed the title fix(deps): bump ckeditor family from 37.1.0 to v39 (main) (major) fix(deps): bump ckeditor family from 37.1.0 to v40 (main) (major) Oct 4, 2023
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from c064b22 to eac28f3 Compare October 5, 2023 07:20
@renovate renovate bot changed the title fix(deps): bump ckeditor family from 37.1.0 to v40 (main) (major) fix(deps): bump ckeditor family (main) (major) Oct 5, 2023
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from 46df855 to c21ed19 Compare October 19, 2023 08:24
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from a115a27 to ac6eca5 Compare October 30, 2023 09:27
@renovate renovate bot requested a review from ChristophWurst as a code owner October 30, 2023 09:27
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from 737ed98 to 36bfc52 Compare August 13, 2024 08:56
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from d175b1a to ad8c035 Compare September 5, 2024 10:34
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from 8b7ea29 to dc4d1f1 Compare September 13, 2024 23:13
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 3 times, most recently from 34538c0 to 2238300 Compare October 2, 2024 09:09
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 2238300 to 90591d7 Compare October 2, 2024 12:40
@kesselb kesselb self-assigned this Oct 3, 2024
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 90591d7 to fd4e919 Compare October 3, 2024 10:40
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from fd4e919 to 573b041 Compare October 16, 2024 11:45
@ChristophWurst
Copy link
Member

I talked with @jancborchardt about this and CKEditor is GPLv2 and our code is AGPLv3-or-later so the code bases are compatible and we are allowed to modify the editor.
As an alternative for the in-place logo we will credit CKEditor in the README.md of this repo and an "About" section of the app settings modal.

@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from bb913be to 3e22b2e Compare October 29, 2024 12:30
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 3e22b2e to ef86e59 Compare November 6, 2024 09:31
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from ef86e59 to 1e7823a Compare November 13, 2024 13:00
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 1e7823a to 92a081a Compare December 2, 2024 10:23
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from be2e24e to a9046c0 Compare December 16, 2024 08:56
@ChristophWurst ChristophWurst assigned GretaD and unassigned kesselb Jan 9, 2025
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from a9046c0 to 262af77 Compare February 4, 2025 15:50
@renovate
fix(deps): bump ckeditor family
c42d26f 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 262af77 to c42d26f Compare February 12, 2025 10:00
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Feb 13, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@GretaD GretaD

Labels
1. to develop dependencies
Projects
💌 📅 👥 Groupware team
Status: 📄 To do
🖍 Design team
Status: 🏗️ At engineering
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ChristophWurst @nimishavijay @kesselb @jancborchardt @marcoambrosini @GretaD